You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by dkuppitz <gi...@git.apache.org> on 2016/01/04 13:13:30 UTC

[GitHub] incubator-tinkerpop pull request: TINKERPOP-976 Fail earlier if in...

GitHub user dkuppitz opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/190

    TINKERPOP-976 Fail earlier if invalid version is supplied in validate-distribution.sh

    **Invalid version:**
    
    ```
    daniel@cube /projects/apache/dev/incubator-tinkerpop (TINKERPOP-976) $ bin/validate-distribution.sh 3.0.2-incubating
    
    Validating binary distributions
    
    * downloading Apache Gremlin Console (apache-gremlin-console-3.0.2-incubating-bin.zip)... Failed to download Apache Gremlin Console
    ```
    
    **Valid version:**
    
    ```
    daniel@cube /projects/apache/dev/incubator-tinkerpop (TINKERPOP-976) $ bin/validate-distribution.sh 3.1.0-incubating
    
    Validating binary distributions
    
    * downloading Apache Gremlin Console (apache-gremlin-console-3.1.0-incubating-bin.zip)... OK
    * validating signatures and checksums ... 
      * PGP signature ... OK
      * MD5 checksum ... OK
      * SHA1 chacksum ... OK
    * unzipping Apache Gremlin Console ... OK
    * validating Apache Gremlin Console's docs ... OK
    * validating Apache Gremlin Console's binaries ... OK
    * validating Apache Gremlin Console's legal files ... 
      * LICENSE ... OK
      * NOTICE ... OK
      * DISCLAIMER ... OK
    * validating Apache Gremlin Console's plugin directory ... OK
    * validating Apache Gremlin Console's lib directory ... OK
    * testing script evaluation ... OK
    
    * downloading Apache Gremlin Server (apache-gremlin-server-3.1.0-incubating-bin.zip)... OK
    * validating signatures and checksums ... 
      * PGP signature ... OK
      * MD5 checksum ... OK
      * SHA1 chacksum ... OK
    * unzipping Apache Gremlin Server ... OK
    * validating Apache Gremlin Server's docs ... OK
    * validating Apache Gremlin Server's binaries ... OK
    * validating Apache Gremlin Server's legal files ... 
      * LICENSE ... OK
      * NOTICE ... OK
      * DISCLAIMER ... OK
    * validating Apache Gremlin Server's plugin directory ... OK
    * validating Apache Gremlin Server's lib directory ... OK
    
    Validating source distribution
    
    * downloading Apache Tinkerpop 3.1.0 (apache-tinkerpop-3.1.0-incubating-src.zip)... OK
    * validating signatures and checksums ... 
      * PGP signature ... OK
      * MD5 checksum ... OK
      * SHA1 chacksum ... OK
    * unzipping Apache Tinkerpop 3.1.0 ... OK
    * building project ... OK
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-976

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #190
    
----
commit f4be739e7a61920d274834f3b68ed1ccedf633af
Author: Daniel Kuppitz <da...@hotmail.com>
Date:   2016-01-04T12:08:22Z

    fail earlier if download of distribution files fails

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-976 Fail earlier if in...

Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/190#issuecomment-168698424
  
    I ensured that `curl -Lsf` works on Mac. It does.
    
    VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-976 Fail earlier if in...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/190#issuecomment-168699717
  
    I gave this a full test - works nicely.  
    
    VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-976 Fail earlier if in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/190


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---