You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/12 15:36:29 UTC

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #2286: stm32f0l0g0/stm32_dmamux.h: Fix errors in bitfield definitions

hartmannathan opened a new pull request #2286:
URL: https://github.com/apache/incubator-nuttx/pull/2286


   ## Summary
   
   Fix errors in DMAMUX register bitfield definitions.
   
   Used reference manual for STM32G071CB. The F0 and L0 families do not appear to have a DMAMUX.
   
   arch/arm/src/stm32f0l0g0/hardware/stm32_dmamux.h:
   
       * Remove all mentions of DMAMUX12 from comments. This family has
         at most DMAMUX1 only.
   
       * Add missing defines DMAMUX_CCR_SPOL_NONE,
         DMAMUX_CCR_SPOL_RISING, DMAMUX_CCR_SPOL_FALLING, and
         DMAMUX_CCR_SPOL_BOTH.
   
       * DMAMUX_CCR_SYNCID_SHIFT: Fix comment. Was "Bits 24-26" (3 bits)
         but datasheet shows bits 24-28 (5 bits).
   
       * DMAMUX_CCR_SYNCID_MASK: Fix mask. Was 0x7 (3 bits) but datasheet
         shows (5 bits) 0x1f.
   
       * DMAMUX1_CSR_SOF(x): Add parenthesis around macro parameter
         expansion.
   
       * DMAMUX1_CFR_SOF(x): Rename to DMAMUX1_CFR_CSOF(x) for
         consistency with datasheet and add parenthesis around macro
         parameter expansion.
   
       * DMAMUX_RGCR_GPOL_MASK: Fix incorrect mask. Was 0x7 (3 bits) but
         datasheet shows only 2 bits (0x3).
   
       * Add missing defines DMAMUX_RGCR_GPOL_NONE,
         DMAMUX_RGCR_GPOL_RISING, DMAMUX_RGCR_GPOL_FALLING, and
         DMAMUX_RGCR_GPOL_BOTH.
   
       * DMAMUX_RGCR_GNBREQ_SHIFT: Fix incorrect value. Was 17 (collision
         with DMAMUX_RGCR_GPOL_SHIFT) but datasheet and comment both show
         this bitfield at bits 19-23.
   
       * DMAMUX_RGCR_GNBREQL_MASK: Fix incorrect mask. Was 0x7 (3 bits)
         but datasheet shows 5 bits (0x1f).
   
       * DMAMUX1_RGSR_SOF(x): Rename to DMAMUX1_RGSR_OF(x) for
         consistency with datasheet and add parenthesis around macro
         parameter expansion.
   
       * DMAMUX1_RGCFR_SOF(x): Rename to DMAMUX1_RGCFR_COF(x) for
         consistency with datasheet and add parenthesis around macro
         parameter expansion.
   
       * DMAMAP_MAP(d,c): Add parenthesis around macro parameter
         expansion.
   
       * Fix nxstyle errors.
   
   ## Impact
   
   Corrects bitfield mistakes.
   
   ## Testing
   
   nxstyle


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2286: stm32f0l0g0/stm32_dmamux.h: Fix errors in bitfield definitions

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2286:
URL: https://github.com/apache/incubator-nuttx/pull/2286


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2286: stm32f0l0g0/stm32_dmamux.h: Fix errors in bitfield definitions

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2286:
URL: https://github.com/apache/incubator-nuttx/pull/2286#issuecomment-726566052


   LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org