You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/17 13:54:34 UTC
[GitHub] [superset] kgabryje opened a new pull request #19236: chore: Make font-weights themable, fix font faces
kgabryje opened a new pull request #19236:
URL: https://github.com/apache/superset/pull/19236
### SUMMARY
1. Due to incorrect import of fonts in `src/assets/stylesheets/less/fonts.less`, in fact only the fonts with normal font weight were available. That means that font weights other than 400 simply didn't work - weights from 200 to 500 were rendered as 400, bold font weights were extrapolated by the browser. This PR fixes that issue by explicitely importing font files with weights 200, 400, 500 and 600.
2. After the change described above, font-weight 700 (bold) was too thick. I replaced all 700 weights with 600, so that all texts look similar to how they looked before.
3. HTML tags `<h1-6>`, `<th>` and `<strong>` all use `font-weight: 700` by default. I've overriden them globally to use `font-weight: 600`.
4. I changed the value of bold font weight in `supersetTheme` from 700 to 600, because of the reasons described above.
5. I replaced hardcoded font weights in many components with superset theme variables. Only a few font weights in some plugins css files remain hardcoded.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
The changes affect the whole product - everything should look as it did before (if you compare side-by-side with current look, there are slight differences in how bold texts look - that's because we didn't actually use Inter font's bold version before).
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r830291741
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/styles.ts
##########
@@ -284,85 +280,86 @@ export const validatedFormStyles = (theme: SupersetTheme) => css`
`;
export const StyledInputContainer = styled.div`
- margin-bottom: ${({ theme }) => theme.gridUnit * 6}px;
- &.mb-0 {
- margin-bottom: 0;
- }
- &.mb-8 {
- margin-bottom: ${({ theme }) => theme.gridUnit * 2}px;
- }
-
- .control-label {
- color: ${({ theme }) => theme.colors.grayscale.dark1};
- font-size: ${({ theme }) => theme.typography.sizes.s - 1}px;
- margin-bottom: ${({ theme }) => theme.gridUnit * 2}px;
- }
+ ${({ theme }) => css`
+ margin-bottom: ${theme.gridUnit * 6}px;
+ &.mb-0 {
+ margin-bottom: 0;
+ }
+ &.mb-8 {
+ margin-bottom: ${theme.gridUnit * 2}px;
+ }
- &.extra-container {
- padding-top: 8px;
- }
+ .control-label {
+ color: ${theme.colors.grayscale.dark1};
+ font-size: ${theme.typography.sizes.s - 1}px;
+ margin-bottom: ${theme.gridUnit * 2}px;
+ }
- .input-container {
- display: flex;
- align-items: top;
+ &.extra-container {
+ padding-top: 8px;
Review comment:
```suggestion
padding-top: ${theme.gridUnit * 2}px;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19236:
URL: https://github.com/apache/superset/pull/19236#issuecomment-1072349478
@kgabryje Ephemeral environment spinning up at http://34.213.199.151:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r830266329
##########
File path: superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.js
##########
@@ -17,123 +17,124 @@
* under the License.
*/
-import { styled } from '@superset-ui/core';
+import { css, styled } from '@superset-ui/core';
export const Styles = styled.div`
- table.pvtTable {
- position: relative;
- font-size: 12px;
- text-align: left;
- margin-top: 3px;
- margin-left: 3px;
- border-collapse: separate;
- font-family: 'Inter', Helvetica, Arial, sans-serif;
- line-height: 1.4;
- }
-
- table thead {
- position: sticky;
- top: 0;
- }
-
- table.pvtTable thead tr th,
- table.pvtTable tbody tr th {
- background-color: #fff;
- border-top: 1px solid #e0e0e0;
- border-left: 1px solid #e0e0e0;
- font-size: 12px;
- padding: 5px;
- font-weight: normal;
- }
-
- table.pvtTable tbody tr.pvtRowTotals {
- position: sticky;
- bottom: 0;
- }
-
- table.pvtTable thead tr:last-of-type th,
- table.pvtTable thead tr:first-of-type th.pvtTotalLabel,
- table.pvtTable thead tr:nth-last-of-type(2) th.pvtColLabel,
- table.pvtTable thead th.pvtSubtotalLabel,
- table.pvtTable tbody tr:last-of-type th,
- table.pvtTable tbody tr:last-of-type td {
- border-bottom: 1px solid #e0e0e0;
- }
-
- table.pvtTable
- thead
- tr:last-of-type:not(:only-child)
- th.pvtAxisLabel
- ~ th.pvtColLabel,
- table.pvtTable tbody tr:first-of-type th,
- table.pvtTable tbody tr:first-of-type td {
- border-top: none;
- }
-
- table.pvtTable tbody tr td:last-of-type,
- table.pvtTable thead tr th:last-of-type:not(.pvtSubtotalLabel) {
- border-right: 1px solid #e0e0e0;
- }
-
- table.pvtTable
- thead
- tr:last-of-type:not(:only-child)
- th.pvtAxisLabel
- + .pvtTotalLabel {
- border-right: none;
- }
-
- table.pvtTable tr th.active {
- background-color: #d9dbe4;
- }
-
- table.pvtTable .pvtTotalLabel {
- text-align: right;
- font-weight: bold;
- }
-
- table.pvtTable .pvtSubtotalLabel {
- font-weight: bold;
- }
-
- table.pvtTable tbody tr td {
- color: #2a3f5f;
- padding: 5px;
- background-color: #fff;
- border-top: 1px solid #e0e0e0;
- border-left: 1px solid #e0e0e0;
- vertical-align: top;
- text-align: right;
- }
-
- table.pvtTable tbody tr th.pvtRowLabel {
- vertical-align: baseline;
- }
-
- .pvtTotal,
- .pvtGrandTotal {
- font-weight: bold;
- }
-
- table.pvtTable tbody tr td.pvtRowTotal {
- vertical-align: middle;
- }
-
- .toggle-wrapper {
- white-space: nowrap;
- }
-
- .toggle-wrapper > .toggle-val {
- white-space: normal;
- }
-
- .toggle {
- padding-right: 4px;
- cursor: pointer;
- }
-
- .hoverable:hover {
- background-color: #eceef2;
- cursor: pointer;
- }
+ ${({ theme }) => css`
+ table.pvtTable {
+ position: relative;
+ font-size: ${theme.typography.sizes.s}px;
+ text-align: left;
+ margin: ${theme.gridUnit}px;
+ border-collapse: separate;
+ font-family: 'Inter', Helvetica, Arial, sans-serif;
Review comment:
```suggestion
font-family: ${theme.typography.families.sansSerif};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19236:
URL: https://github.com/apache/superset/pull/19236#issuecomment-1071041457
# [Codecov](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19236](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54db12a) into [master](https://codecov.io/gh/apache/superset/commit/30c97ad5bfe1dc9b074efc294c647c32fdd05fe0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30c97ad) will **increase** coverage by `0.16%`.
> The diff coverage is `80.95%`.
> :exclamation: Current head 54db12a differs from pull request most recent head f5d4d7c. Consider uploading reports for the commit f5d4d7c to get more accurate results
```diff
@@ Coverage Diff @@
## master #19236 +/- ##
==========================================
+ Coverage 66.55% 66.71% +0.16%
==========================================
Files 1646 1669 +23
Lines 63617 64239 +622
Branches 6471 6496 +25
==========================================
+ Hits 42339 42858 +519
- Misses 19600 19699 +99
- Partials 1678 1682 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.26% <55.60%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXNhbmtleS9zcmMvUmVhY3RTYW5rZXkuanN4) | `0.00% <ø> (ø)` | |
| [...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlclZpei50c3g=) | `0.00% <ø> (ø)` | |
| [...n-chart-pivot-table/src/react-pivottable/Styles.js](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGl2b3QtdGFibGUvc3JjL3JlYWN0LXBpdm90dGFibGUvU3R5bGVzLmpz) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/GlobalStyles.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0dsb2JhbFN0eWxlcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <ø> (ø)` | |
| [...d/src/SqlLab/components/AceEditorWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIvaW5kZXgudHN4) | `44.82% <0.00%> (-8.75%)` | :arrow_down: |
| [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `50.84% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/components/AnchorLink/index.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay9pbmRleC5qc3g=) | `80.00% <ø> (ø)` | |
| ... and [142 more](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [30c97ad...f5d4d7c](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #19236:
URL: https://github.com/apache/superset/pull/19236#issuecomment-1072348150
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r830256617
##########
File path: superset-frontend/packages/superset-ui-core/src/chart/components/NoResultsComponent.tsx
##########
@@ -17,31 +17,38 @@
* under the License.
*/
-import React, { CSSProperties, useMemo } from 'react';
+import React, { CSSProperties } from 'react';
+import { css, styled } from '../../style';
import { t } from '../../translation';
const MESSAGE_STYLES: CSSProperties = { maxWidth: 800 };
-const TITLE_STYLES: CSSProperties = {
- fontSize: 16,
- fontWeight: 'bold',
- paddingBottom: 8,
-};
-const BODY_STYLES: CSSProperties = { fontSize: 14 };
const MIN_WIDTH_FOR_BODY = 250;
-const generateContainerStyles: (
- height: number | string,
- width: number | string,
-) => CSSProperties = (height: number | string, width: number | string) => ({
- alignItems: 'center',
- display: 'flex',
- flexDirection: 'column',
- height,
- justifyContent: 'center',
- padding: 16,
- textAlign: 'center',
- width,
-});
+const Container = styled.div<{
+ width: number | string;
+ height: number | string;
+}>`
+ ${({ theme, width, height }) => css`
+ align-items: center;
+ display: flex;
+ flex-direction: column;
+ justify-content: center;
+ text-align: center;
+ height: ${height}px;
+ width: ${width}px;
+ //padding: ${theme.gridUnit * 4}px;
Review comment:
Should we uncomment it or delete it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r830281918
##########
File path: superset-frontend/src/GlobalStyles.tsx
##########
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { css } from '@superset-ui/core';
+import { Global } from '@emotion/react';
+
+export const GlobalStyles = () => (
Review comment:
If you search for `<Global` you'll find only 8 files. It would be a BIG plus to move these styles to this file and create a linting rule that prevents any `Global` declaration outside this file. You can do this in another PR if you think it's out of scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r831279303
##########
File path: superset-frontend/packages/superset-ui-core/src/chart/components/NoResultsComponent.tsx
##########
@@ -17,31 +17,38 @@
* under the License.
*/
-import React, { CSSProperties, useMemo } from 'react';
+import React, { CSSProperties } from 'react';
+import { css, styled } from '../../style';
import { t } from '../../translation';
const MESSAGE_STYLES: CSSProperties = { maxWidth: 800 };
-const TITLE_STYLES: CSSProperties = {
- fontSize: 16,
- fontWeight: 'bold',
- paddingBottom: 8,
-};
-const BODY_STYLES: CSSProperties = { fontSize: 14 };
const MIN_WIDTH_FOR_BODY = 250;
-const generateContainerStyles: (
- height: number | string,
- width: number | string,
-) => CSSProperties = (height: number | string, width: number | string) => ({
- alignItems: 'center',
- display: 'flex',
- flexDirection: 'column',
- height,
- justifyContent: 'center',
- padding: 16,
- textAlign: 'center',
- width,
-});
+const Container = styled.div<{
+ width: number | string;
+ height: number | string;
+}>`
+ ${({ theme, width, height }) => css`
+ align-items: center;
+ display: flex;
+ flex-direction: column;
+ justify-content: center;
+ text-align: center;
+ height: ${height}px;
+ width: ${width}px;
+ //padding: ${theme.gridUnit * 4}px;
Review comment:
Commented by mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r830286983
##########
File path: superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
##########
@@ -16,68 +16,70 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { styled } from '@superset-ui/core';
+import { css, styled } from '@superset-ui/core';
export const Pill = styled.div`
- display: inline-block;
- color: ${({ theme }) => theme.colors.grayscale.light5};
- background: ${({ theme }) => theme.colors.grayscale.base};
- border-radius: 1em;
- vertical-align: text-top;
- padding: ${({ theme }) => `${theme.gridUnit}px ${theme.gridUnit * 2}px`};
- font-size: ${({ theme }) => theme.typography.sizes.m}px;
- font-weight: bold;
- min-width: 1em;
- min-height: 1em;
- line-height: 1em;
- vertical-align: middle;
- white-space: nowrap;
-
- svg {
- position: relative;
- top: -2px;
- color: ${({ theme }) => theme.colors.grayscale.light5};
- width: 1em;
- height: 1em;
+ ${({ theme }) => css`
display: inline-block;
+ color: ${theme.colors.grayscale.light5};
+ background: ${theme.colors.grayscale.base};
+ border-radius: 1em;
+ vertical-align: text-top;
+ padding: ${`${theme.gridUnit}px ${theme.gridUnit * 2}px`};
Review comment:
```suggestion
padding: ${theme.gridUnit}px ${theme.gridUnit * 2}px;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r831263076
##########
File path: superset-frontend/src/GlobalStyles.tsx
##########
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { css } from '@superset-ui/core';
+import { Global } from '@emotion/react';
+
+export const GlobalStyles = () => (
Review comment:
I think that creating a new eslint rule deserves a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r831268637
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/styles.ts
##########
@@ -284,85 +280,86 @@ export const validatedFormStyles = (theme: SupersetTheme) => css`
`;
export const StyledInputContainer = styled.div`
- margin-bottom: ${({ theme }) => theme.gridUnit * 6}px;
- &.mb-0 {
- margin-bottom: 0;
- }
- &.mb-8 {
- margin-bottom: ${({ theme }) => theme.gridUnit * 2}px;
- }
-
- .control-label {
- color: ${({ theme }) => theme.colors.grayscale.dark1};
- font-size: ${({ theme }) => theme.typography.sizes.s - 1}px;
- margin-bottom: ${({ theme }) => theme.gridUnit * 2}px;
- }
+ ${({ theme }) => css`
+ margin-bottom: ${theme.gridUnit * 6}px;
+ &.mb-0 {
+ margin-bottom: 0;
+ }
+ &.mb-8 {
+ margin-bottom: ${theme.gridUnit * 2}px;
+ }
- &.extra-container {
- padding-top: 8px;
- }
+ .control-label {
+ color: ${theme.colors.grayscale.dark1};
+ font-size: ${theme.typography.sizes.s - 1}px;
Review comment:
I really don't like "hacking" our theme like that, but I'm kinda nervous about making such changes in this PR... It's not obvious if it should be `s` or `xs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19236:
URL: https://github.com/apache/superset/pull/19236#issuecomment-1071041457
# [Codecov](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19236](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54db12a) into [master](https://codecov.io/gh/apache/superset/commit/30c97ad5bfe1dc9b074efc294c647c32fdd05fe0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30c97ad) will **increase** coverage by `0.16%`.
> The diff coverage is `80.95%`.
> :exclamation: Current head 54db12a differs from pull request most recent head a3f3e43. Consider uploading reports for the commit a3f3e43 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19236 +/- ##
==========================================
+ Coverage 66.55% 66.71% +0.16%
==========================================
Files 1646 1669 +23
Lines 63617 64239 +622
Branches 6471 6496 +25
==========================================
+ Hits 42339 42858 +519
- Misses 19600 19699 +99
- Partials 1678 1682 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.26% <55.60%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXNhbmtleS9zcmMvUmVhY3RTYW5rZXkuanN4) | `0.00% <ø> (ø)` | |
| [...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlclZpei50c3g=) | `0.00% <ø> (ø)` | |
| [...n-chart-pivot-table/src/react-pivottable/Styles.js](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGl2b3QtdGFibGUvc3JjL3JlYWN0LXBpdm90dGFibGUvU3R5bGVzLmpz) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/GlobalStyles.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0dsb2JhbFN0eWxlcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <ø> (ø)` | |
| [...d/src/SqlLab/components/AceEditorWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIvaW5kZXgudHN4) | `44.82% <0.00%> (-8.75%)` | :arrow_down: |
| [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `50.84% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/components/AnchorLink/index.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay9pbmRleC5qc3g=) | `80.00% <ø> (ø)` | |
| ... and [142 more](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [30c97ad...a3f3e43](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r830264183
##########
File path: superset-frontend/packages/superset-ui-core/test/chart/components/SuperChart.test.tsx
##########
@@ -18,12 +18,14 @@
*/
import React from 'react';
-import { mount } from 'enzyme';
import mockConsole, { RestoreConsole } from 'jest-mock-console';
import { triggerResizeObserver } from 'resize-observer-polyfill';
import ErrorBoundary from 'react-error-boundary';
import { promiseTimeout, SuperChart } from '@superset-ui/core';
+// @ts-ignore
+// eslint-disable-next-line import/no-extraneous-dependencies
Review comment:
I'm not sure if we should create this dependency. Especially because we're moving the files in `spec` to `src`. Maybe let's just copy `styledMount` logic for now while we think about cyclic dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #19236:
URL: https://github.com/apache/superset/pull/19236#issuecomment-1072680370
@jinghua-qa Can you please help us test this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r831278849
##########
File path: superset-frontend/packages/superset-ui-core/test/chart/components/SuperChart.test.tsx
##########
@@ -18,12 +18,14 @@
*/
import React from 'react';
-import { mount } from 'enzyme';
import mockConsole, { RestoreConsole } from 'jest-mock-console';
import { triggerResizeObserver } from 'resize-observer-polyfill';
import ErrorBoundary from 'react-error-boundary';
import { promiseTimeout, SuperChart } from '@superset-ui/core';
+// @ts-ignore
+// eslint-disable-next-line import/no-extraneous-dependencies
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje closed pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #19236:
URL: https://github.com/apache/superset/pull/19236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19236:
URL: https://github.com/apache/superset/pull/19236#issuecomment-1072349478
@kgabryje Ephemeral environment spinning up at http://34.213.199.151:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje closed pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #19236:
URL: https://github.com/apache/superset/pull/19236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19236:
URL: https://github.com/apache/superset/pull/19236#issuecomment-1071041457
# [Codecov](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19236](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a3f3e43) into [master](https://codecov.io/gh/apache/superset/commit/30c97ad5bfe1dc9b074efc294c647c32fdd05fe0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30c97ad) will **decrease** coverage by `0.00%`.
> The diff coverage is `60.00%`.
```diff
@@ Coverage Diff @@
## master #19236 +/- ##
==========================================
- Coverage 66.55% 66.54% -0.01%
==========================================
Files 1646 1645 -1
Lines 63617 63713 +96
Branches 6471 6503 +32
==========================================
+ Hits 42339 42398 +59
- Misses 19600 19632 +32
- Partials 1678 1683 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.29% <60.00%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXNhbmtleS9zcmMvUmVhY3RTYW5rZXkuanN4) | `0.00% <ø> (ø)` | |
| [...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlclZpei50c3g=) | `0.00% <ø> (ø)` | |
| [...n-chart-pivot-table/src/react-pivottable/Styles.js](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGl2b3QtdGFibGUvc3JjL3JlYWN0LXBpdm90dGFibGUvU3R5bGVzLmpz) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/GlobalStyles.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0dsb2JhbFN0eWxlcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <ø> (ø)` | |
| [...set-frontend/src/components/ReportModal/styles.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvc3R5bGVzLnRzeA==) | `100.00% <ø> (ø)` | |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `55.55% <ø> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <ø> (ø)` | |
| ... and [129 more](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [30c97ad...a3f3e43](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
kgabryje merged pull request #19236:
URL: https://github.com/apache/superset/pull/19236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #19236:
URL: https://github.com/apache/superset/pull/19236#issuecomment-1072348150
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r830256617
##########
File path: superset-frontend/packages/superset-ui-core/src/chart/components/NoResultsComponent.tsx
##########
@@ -17,31 +17,38 @@
* under the License.
*/
-import React, { CSSProperties, useMemo } from 'react';
+import React, { CSSProperties } from 'react';
+import { css, styled } from '../../style';
import { t } from '../../translation';
const MESSAGE_STYLES: CSSProperties = { maxWidth: 800 };
-const TITLE_STYLES: CSSProperties = {
- fontSize: 16,
- fontWeight: 'bold',
- paddingBottom: 8,
-};
-const BODY_STYLES: CSSProperties = { fontSize: 14 };
const MIN_WIDTH_FOR_BODY = 250;
-const generateContainerStyles: (
- height: number | string,
- width: number | string,
-) => CSSProperties = (height: number | string, width: number | string) => ({
- alignItems: 'center',
- display: 'flex',
- flexDirection: 'column',
- height,
- justifyContent: 'center',
- padding: 16,
- textAlign: 'center',
- width,
-});
+const Container = styled.div<{
+ width: number | string;
+ height: number | string;
+}>`
+ ${({ theme, width, height }) => css`
+ align-items: center;
+ display: flex;
+ flex-direction: column;
+ justify-content: center;
+ text-align: center;
+ height: ${height}px;
+ width: ${width}px;
+ //padding: ${theme.gridUnit * 4}px;
Review comment:
Should we uncomment or delete it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r830290705
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal/styles.ts
##########
@@ -284,85 +280,86 @@ export const validatedFormStyles = (theme: SupersetTheme) => css`
`;
export const StyledInputContainer = styled.div`
- margin-bottom: ${({ theme }) => theme.gridUnit * 6}px;
- &.mb-0 {
- margin-bottom: 0;
- }
- &.mb-8 {
- margin-bottom: ${({ theme }) => theme.gridUnit * 2}px;
- }
-
- .control-label {
- color: ${({ theme }) => theme.colors.grayscale.dark1};
- font-size: ${({ theme }) => theme.typography.sizes.s - 1}px;
- margin-bottom: ${({ theme }) => theme.gridUnit * 2}px;
- }
+ ${({ theme }) => css`
+ margin-bottom: ${theme.gridUnit * 6}px;
+ &.mb-0 {
+ margin-bottom: 0;
+ }
+ &.mb-8 {
+ margin-bottom: ${theme.gridUnit * 2}px;
+ }
- &.extra-container {
- padding-top: 8px;
- }
+ .control-label {
+ color: ${theme.colors.grayscale.dark1};
+ font-size: ${theme.typography.sizes.s - 1}px;
Review comment:
Do we really need the `-1`? Can't we just change it to `s`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19236:
URL: https://github.com/apache/superset/pull/19236#issuecomment-1071041457
# [Codecov](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19236](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54db12a) into [master](https://codecov.io/gh/apache/superset/commit/30c97ad5bfe1dc9b074efc294c647c32fdd05fe0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30c97ad) will **increase** coverage by `0.16%`.
> The diff coverage is `80.95%`.
> :exclamation: Current head 54db12a differs from pull request most recent head f5d4d7c. Consider uploading reports for the commit f5d4d7c to get more accurate results
```diff
@@ Coverage Diff @@
## master #19236 +/- ##
==========================================
+ Coverage 66.55% 66.71% +0.16%
==========================================
Files 1646 1669 +23
Lines 63617 64239 +622
Branches 6471 6496 +25
==========================================
+ Hits 42339 42858 +519
- Misses 19600 19699 +99
- Partials 1678 1682 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.26% <55.60%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXNhbmtleS9zcmMvUmVhY3RTYW5rZXkuanN4) | `0.00% <ø> (ø)` | |
| [...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlclZpei50c3g=) | `0.00% <ø> (ø)` | |
| [...n-chart-pivot-table/src/react-pivottable/Styles.js](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGl2b3QtdGFibGUvc3JjL3JlYWN0LXBpdm90dGFibGUvU3R5bGVzLmpz) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/GlobalStyles.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0dsb2JhbFN0eWxlcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <ø> (ø)` | |
| [...d/src/SqlLab/components/AceEditorWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIvaW5kZXgudHN4) | `44.82% <0.00%> (-8.75%)` | :arrow_down: |
| [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `50.84% <ø> (ø)` | |
| [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <ø> (ø)` | |
| [...erset-frontend/src/components/AnchorLink/index.jsx](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay9pbmRleC5qc3g=) | `80.00% <ø> (ø)` | |
| ... and [142 more](https://codecov.io/gh/apache/superset/pull/19236/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [30c97ad...f5d4d7c](https://codecov.io/gh/apache/superset/pull/19236?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19236:
URL: https://github.com/apache/superset/pull/19236#issuecomment-1074881407
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #19236: chore: Make font-weights themable, fix font faces
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #19236:
URL: https://github.com/apache/superset/pull/19236#discussion_r831263325
##########
File path: superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
##########
@@ -16,68 +16,70 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { styled } from '@superset-ui/core';
+import { css, styled } from '@superset-ui/core';
export const Pill = styled.div`
- display: inline-block;
- color: ${({ theme }) => theme.colors.grayscale.light5};
- background: ${({ theme }) => theme.colors.grayscale.base};
- border-radius: 1em;
- vertical-align: text-top;
- padding: ${({ theme }) => `${theme.gridUnit}px ${theme.gridUnit * 2}px`};
- font-size: ${({ theme }) => theme.typography.sizes.m}px;
- font-weight: bold;
- min-width: 1em;
- min-height: 1em;
- line-height: 1em;
- vertical-align: middle;
- white-space: nowrap;
-
- svg {
- position: relative;
- top: -2px;
- color: ${({ theme }) => theme.colors.grayscale.light5};
- width: 1em;
- height: 1em;
+ ${({ theme }) => css`
display: inline-block;
+ color: ${theme.colors.grayscale.light5};
+ background: ${theme.colors.grayscale.base};
+ border-radius: 1em;
+ vertical-align: text-top;
+ padding: ${`${theme.gridUnit}px ${theme.gridUnit * 2}px`};
Review comment:
🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org