You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/30 15:28:34 UTC

[GitHub] [kafka] C0urante opened a new pull request #10945: KAFKA-13017: Remove excessive logging for sink task deserialization errors

C0urante opened a new pull request #10945:
URL: https://github.com/apache/kafka/pull/10945


   [Jira](https://issues.apache.org/jira/browse/KAFKA-13017)
   
   Reverts https://github.com/apache/kafka/pull/7496, which added `ERROR`-level logging for deserialization errors in sink tasks even when connectors had logging for these errors disabled.
   
   No information is lost by this change that cannot be retained in an opt-in fashion by setting `errors.log.enable` and `errors.log.include.messages` to `true` in a connector config.
   
   No testing is added. This commit was created via the GitHub UI; best to wait for a clean(ish) CI build before reviewing/merging.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] tombentley commented on pull request #10945: KAFKA-13017: Remove excessive logging for sink task deserialization errors

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #10945:
URL: https://github.com/apache/kafka/pull/10945#issuecomment-880614825


   @rhauch / @kkonstantine do you want to take a look too? If not I'll go ahead and merge. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #10945: KAFKA-13017: Remove excessive logging for sink task deserialization errors

Posted by GitBox <gi...@apache.org>.
C0urante commented on pull request #10945:
URL: https://github.com/apache/kafka/pull/10945#issuecomment-881511869


   Thanks @tombentley! It'd be great to cherry-pick if possible but only if that doesn't disrupt the release process (this isn't a new regression and has been around for several prior releases).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] tombentley commented on pull request #10945: KAFKA-13017: Remove excessive logging for sink task deserialization errors

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #10945:
URL: https://github.com/apache/kafka/pull/10945#issuecomment-878974936


   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #10945: KAFKA-13017: Remove excessive logging for sink task deserialization errors

Posted by GitBox <gi...@apache.org>.
C0urante commented on pull request #10945:
URL: https://github.com/apache/kafka/pull/10945#issuecomment-878477034


   @rhauch @tombentley any chance you could take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] tombentley merged pull request #10945: KAFKA-13017: Remove excessive logging for sink task deserialization errors

Posted by GitBox <gi...@apache.org>.
tombentley merged pull request #10945:
URL: https://github.com/apache/kafka/pull/10945


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] tombentley commented on pull request #10945: KAFKA-13017: Remove excessive logging for sink task deserialization errors

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #10945:
URL: https://github.com/apache/kafka/pull/10945#issuecomment-881501052


   @C0urante did you need this cherry picking onto 3.0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org