[GitHub] [flink] JingsongLi commented on a change in pull request #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #10766: [FLINK-15478][table-planner-blink] Fix FROM_BASE64 code gen result type
URL: https://github.com/apache/flink/pull/10766#discussion_r363149820
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala
 ##########
 @@ -260,4 +260,17 @@ class CalcITCase extends StreamingTestBase {
     val expected = List("2,2,Hello", "3,2,Hello world")
     assertEquals(expected.sorted, sink.getAppendResults.sorted)
   }
+
+  @Test
+  def testFromBase64(): Unit = {
 
 Review comment:
   Can you add test in `ScalarFunctionsTest.testFromBase64` instead of it case?
   Maybe you can add a nested function call to verify this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services