[GitHub] [airflow] jedcunningham commented on a change in pull request #22123: Add details drawer to Grid View

[GitBox <gi...@apache.org>]

jedcunningham commented on a change in pull request #22123:
URL: https://github.com/apache/airflow/pull/22123#discussion_r837956949



##########
File path: airflow/www/views.py
##########
@@ -2554,6 +2552,20 @@ def grid(self, dag_id, session=None):
             'dag_runs': encoded_runs,
         }
 
+        dag_details_url = ''
+        tasks_url = ''
+        # This is a workround to use try/except if url_for() throws an error

Review comment:
       The api init step is skipped in those test. Try this instead:
   
   ```
   --- a/tests/www/views/test_views_log.py
   +++ b/tests/www/views/test_views_log.py
   @@ -56,7 +56,12 @@ def backup_modules():
    @pytest.fixture(scope="module")
    def log_app(backup_modules):
        @dont_initialize_flask_app_submodules(
   -        skip_all_except=["init_appbuilder", "init_jinja_globals", "init_appbuilder_views"]
   +        skip_all_except=[
   +            "init_appbuilder",
   +            "init_jinja_globals",
   +            "init_appbuilder_views",
   +            "init_api_connexion",
   +        ]
        )
        @conf_vars({('logging', 'logging_config_class'): 'airflow_local_settings.LOGGING_CONFIG'})
        def factory():
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org