You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/12/21 04:12:52 UTC
[GitHub] incubator-beam pull request #1673: [BEAM-27] Require TimeDomain to delete a ...
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1673
[BEAM-27] Require TimeDomain to delete a timer
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
R: @aljoscha
A bit of an oversight, I neglected the fact that runners generally store different sorts of timers in rather different ways. When a user sets a timer, the `DoFnSignature` is available, so this will be for free. And when system code deletes a timer, the domain will always be known.
This will require a Dataflow update, so don't worry if Dataflow-specific integration tests don't pass.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam delete-by-domain
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1673.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1673
----
commit 46dfd0fb4d2a1533d3ed053983faee6537d3ccf0
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-12-21T04:09:25Z
Require TimeDomain to delete a timer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1673: [BEAM-27] Require TimeDomain to delete a ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/1673
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---