You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "eric baldeschwieler (JIRA)" <ji...@apache.org> on 2007/01/30 01:01:49 UTC
[jira] Created: (HADOOP-958) Building Hadoop results in a lot of
warnings
Building Hadoop results in a lot of warnings
--------------------------------------------
Key: HADOOP-958
URL: https://issues.apache.org/jira/browse/HADOOP-958
Project: Hadoop
Issue Type: Improvement
Reporter: eric baldeschwieler
We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
A) Leads to the perception that our code is of low quality
B) Can mask warnings that come from real issues.
---
I suggest we do two things
1) Submit a patch or set of patches to clean this up
2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475828 ]
Nigel Daley commented on HADOOP-958:
------------------------------------
Tom,
Hudson is running a script, and the script can pretty much do anything we want. I would like to see the number decrease before we put such a scheme in place. Unfortunately, this scheme will likely require the occassional manual intervension when the number of warnings increase for a valid reason.
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468450 ]
Doug Cutting commented on HADOOP-958:
-------------------------------------
Warnings from what? Eclipse? When I build and/or run unit tests from the command line I see no warnings.
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476083 ]
Nigel Daley commented on HADOOP-958:
------------------------------------
+1 on your patch
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
> Attachments: example-warnings.patch
>
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485921 ]
Tom White commented on HADOOP-958:
----------------------------------
I have broken out fixes for unchecked warnings to HADOOP-1190 since they will be done first.
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
> Attachments: example-warnings.patch, fs-unchecked.patch
>
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-958:
-----------------------------
Attachment: example-warnings.patch
As a (very small start) here is a patch that fixes the warnings in the examples.
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
> Attachments: example-warnings.patch
>
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476342 ]
Nigel Daley commented on HADOOP-958:
------------------------------------
Ok, the patch process will now -1 a patch that increases the number of javac warnings. As the number of warnings decrease, the max allowed warnings will also decrease to match the last smallest number of warnings. It's had minimal testing.
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
> Attachments: example-warnings.patch
>
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "eric baldeschwieler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476379 ]
eric baldeschwieler commented on HADOOP-958:
--------------------------------------------
cool!
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
> Attachments: example-warnings.patch
>
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485309 ]
Tom White commented on HADOOP-958:
----------------------------------
On 29/03/07, Doug Cutting <cu...@apache.org> wrote:
> I think for this issue, which is not completely automatic, my hunch is
> to pursue it piecemeal. Also, as we more actively maintain multiple
> branches, the notions of just-before or just-after a release don't make
> quite as much sense, since these changes will affect merging. So doing
> it all at once in one release will make all merging harder for that
> release, while spreading it over multiple releases will spread the merge
> pain out. That said, if someone has a patch ready that updates the
> whole tree and that applies cleanly to trunk at a time when the patch
> queue is empty, then I'd vote to just commit it and deal with the
> consequences. However the patch queue hasn't been empty for a while...
My patch of three days ago has already been invalidated by other patches. So in practice I think this has to be done piecemeal. If the pieces can be applied in quick succession then great, but that may not be easy either. I agree about keeping them to one release though, and hope that would be possible.
I will try to get back to this when the patch queue clears...
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
> Attachments: example-warnings.patch, fs-unchecked.patch
>
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475989 ]
Tom White commented on HADOOP-958:
----------------------------------
On 26/02/07, Nigel Daley <nd...@yahoo-inc.com> wrote:
> If I remember correctly, -Xlint only shows the first 100 warnings, so
> until our warning count is < 100, this scheme won't work. Please
> correct me if I'm wrong here.
By default this is true. However, you can use the -Xmaxwarns setting to increase the limit. I just tried this and I got the following counts for the core code:
-Xlint:unchecked 250
-Xlint:deprecation 256
-Xlint 579 (this includes unchecked and deprecation)
My feeling is that we should tackle unchecked and deprecation warnings. Unchecked are fairly mechanical - basically replace raw types with parameterized types. Deprecations need handling on a case-by-case basis, since some things need refactoring to avoid use of deprecated features (e.g. see deprecated methods in FileSystem).
What do people think the best way to approach this would be? Create a series of patches (by package)? Do we need patches for the more mechanical changes (e.g. some of the generics changes), or could committers just do it? Is there a way of minimising the impact on people's patches?
>
> I like the idea of using @SuppressWarnings annotation where appropriate.
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (HADOOP-958) Building Hadoop results in a lot
of warnings
Posted by Doug Cutting <cu...@apache.org>.
Nigel Daley wrote:
> Should we try to do all code format changes in a series of contiguous
> patches?
This is more than a format change, but I see what you mean.
> This should minimize the amount of pain while diff'ing source
> files across revisions. Also, should these format changes be the last
> patches applied before a release or the first patches applied after a
> release?
I think for this issue, which is not completely automatic, my hunch is
to pursue it piecemeal. Also, as we more actively maintain multiple
branches, the notions of just-before or just-after a release don't make
quite as much sense, since these changes will affect merging. So doing
it all at once in one release will make all merging harder for that
release, while spreading it over multiple releases will spread the merge
pain out. That said, if someone has a patch ready that updates the
whole tree and that applies cleanly to trunk at a time when the patch
queue is empty, then I'd vote to just commit it and deal with the
consequences. However the patch queue hasn't been empty for a while...
Doug
Re: [jira] Commented: (HADOOP-958) Building Hadoop results in a lot of warnings
Posted by Nigel Daley <nd...@yahoo-inc.com>.
>> if a series of patches like this one are committed, is it OK to do
>> them all under one Jira issue?
>
> As long as they all make it in a single release, this is fine with
> me. In theory we can even map issues to multiple releases, each in
> which they're partially fixed, but that could get confusing and I
> find it simpler when the set of issues in subsequent releases are
> disjoint.
Should we try to do all code format changes in a series of contiguous
patches? This should minimize the amount of pain while diff'ing
source files across revisions. Also, should these format changes be
the last patches applied before a release or the first patches
applied after a release?
On Mar 26, 2007, at 1:30 PM, Doug Cutting (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/HADOOP-958?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel#action_12484219 ]
>
> Doug Cutting commented on HADOOP-958:
> -------------------------------------
>
>> if a series of patches like this one are committed, is it OK to do
>> them all under one Jira issue?
>
> As long as they all make it in a single release, this is fine with
> me. In theory we can even map issues to multiple releases, each in
> which they're partially fixed, but that could get confusing and I
> find it simpler when the set of issues in subsequent releases are
> disjoint.
>
>> Building Hadoop results in a lot of warnings
>> --------------------------------------------
>>
>> Key: HADOOP-958
>> URL: https://issues.apache.org/jira/browse/HADOOP-958
>> Project: Hadoop
>> Issue Type: Improvement
>> Reporter: eric baldeschwieler
>> Attachments: example-warnings.patch, fs-unchecked.patch
>>
>>
>> We are getting hundreds of warnings right now. Most of these are
>> a result of our transition to 1.5 and deprecated uses of
>> generics. We should still fix these, since producing lots of
>> warnings:
>> A) Leads to the perception that our code is of low quality
>> B) Can mask warnings that come from real issues.
>> ---
>> I suggest we do two things
>> 1) Submit a patch or set of patches to clean this up
>> 2) Change our patch tester to validate that the number of warnings
>> per build did not go up with this patch
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Commented: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484219 ]
Doug Cutting commented on HADOOP-958:
-------------------------------------
> if a series of patches like this one are committed, is it OK to do them all under one Jira issue?
As long as they all make it in a single release, this is fine with me. In theory we can even map issues to multiple releases, each in which they're partially fixed, but that could get confusing and I find it simpler when the set of issues in subsequent releases are disjoint.
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
> Attachments: example-warnings.patch, fs-unchecked.patch
>
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-958:
-----------------------------
Attachment: fs-unchecked.patch
Here's a patch for fixing the unchecked warnings in the fs package.
On a process point, if a series of patches like this one are committed, is it OK to do them all under one Jira issue? Is a special commit message needed?
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
> Attachments: example-warnings.patch, fs-unchecked.patch
>
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (HADOOP-958) Building Hadoop results in a lot of warnings
Posted by Nigel Daley <nd...@yahoo-inc.com>.
If I remember correctly, -Xlint only shows the first 100 warnings, so
until our warning count is < 100, this scheme won't work. Please
correct me if I'm wrong here.
I like the idea of using @SuppressWarnings annotation where appropriate.
On Feb 26, 2007, at 12:55 AM, Tom White (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/HADOOP-958?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel#action_12475840 ]
>
> Tom White commented on HADOOP-958:
> ----------------------------------
>
> I saw it the other way round - put in some measures to make sure
> number of warnings did not increase with the patch, then tackle the
> old warnings. I think it would be quite demoralising to submit
> patches that clean up warnings while other patches were being
> applied that inadvertantly increased the warning count.
>
> Regarding the manual intervention, we can mitigate this to some
> extent by using the SuppressWarnings annotation. Alternatively, we
> could make the change in the warning count as an advisory message,
> so committers can use their discretion about applying patches.
>
>> Building Hadoop results in a lot of warnings
>> --------------------------------------------
>>
>> Key: HADOOP-958
>> URL: https://issues.apache.org/jira/browse/HADOOP-958
>> Project: Hadoop
>> Issue Type: Improvement
>> Reporter: eric baldeschwieler
>>
>> We are getting hundreds of warnings right now. Most of these are
>> a result of our transition to 1.5 and deprecated uses of
>> generics. We should still fix these, since producing lots of
>> warnings:
>> A) Leads to the perception that our code is of low quality
>> B) Can mask warnings that come from real issues.
>> ---
>> I suggest we do two things
>> 1) Submit a patch or set of patches to clean this up
>> 2) Change our patch tester to validate that the number of warnings
>> per build did not go up with this patch
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Commented: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475840 ]
Tom White commented on HADOOP-958:
----------------------------------
I saw it the other way round - put in some measures to make sure number of warnings did not increase with the patch, then tackle the old warnings. I think it would be quite demoralising to submit patches that clean up warnings while other patches were being applied that inadvertantly increased the warning count.
Regarding the manual intervention, we can mitigate this to some extent by using the SuppressWarnings annotation. Alternatively, we could make the change in the warning count as an advisory message, so committers can use their discretion about applying patches.
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Milind Bhandarkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468452 ]
Milind Bhandarkar commented on HADOOP-958:
------------------------------------------
Here is what I see when I build from command line:
compile-core-classes:
[javac] Compiling 271 source files to /Users/milindb/Documents/workspace/hadoop/build/classes
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-958:
-----------------------------------
Component/s: dfs
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Reporter: eric baldeschwieler
> Attachments: example-warnings.patch, fs-unchecked.patch
>
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-958) Building Hadoop results in a lot of
warnings
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475760 ]
Tom White commented on HADOOP-958:
----------------------------------
Regarding 2), we could run the patch builds with the ant property javac.args set to -Xlint and then extract that number of warnings from the resulting output (probably using grep and friends). This value could then be compared with the number for the latest nightly build (stored in a file). The build would fail, giving the reason, if the number of warnings increased.
Could we get Hudson to do this, Nigel?
> Building Hadoop results in a lot of warnings
> --------------------------------------------
>
> Key: HADOOP-958
> URL: https://issues.apache.org/jira/browse/HADOOP-958
> Project: Hadoop
> Issue Type: Improvement
> Reporter: eric baldeschwieler
>
> We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
> A) Leads to the perception that our code is of low quality
> B) Can mask warnings that come from real issues.
> ---
> I suggest we do two things
> 1) Submit a patch or set of patches to clean this up
> 2) Change our patch tester to validate that the number of warnings per build did not go up with this patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.