[jira] [Updated] (HBASE-5096) Replication does not handle deletes correctly.

["Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-5096:
---------------------------------

    Attachment: 5096.txt

Simple patch with test.
If I get some +1's I'll commit.
                
> Replication does not handle deletes correctly.
> ----------------------------------------------
>
>                 Key: HBASE-5096
>                 URL: https://issues.apache.org/jira/browse/HBASE-5096
>             Project: HBase
>          Issue Type: Sub-task
>          Components: replication
>    Affects Versions: 0.94.0, 0.92.1
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>         Attachments: 5096.txt
>
>
> Teruyoshi Zenmyo discovered this problem.
> The problem turns out to be this code in ReplicationSink.java:
> {code}
> if (kvs.get(0).isDelete()) {
> ...
>   if (kv.isDeleteFamily()) {
>     delete.deleteFamily(kv.getFamily());
>   } else if (!kv.isEmptyColumn()) {
>     delete.deleteColumn(kv.getFamily(), kv.getQualifier());
>   }
> }
> ...
> {code}
> So the code deal with families delete markers and then assumes that if it's not a family delete marker it must have been a version delete marker.
> (deleteColumn sets a version delete marker, deleteColumns sets a column delete marker).
> I.e. column delete markers are not replicated correctly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira