You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Boris Shkolnik <bo...@apache.org> on 2016/06/07 18:21:10 UTC

Review Request 48352: Added java friendly api to KafkaMetrics

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48352/
-----------------------------------------------------------

Review request for samza and Navina Ramesh.


Bugs: SAMZA-962
    https://issues.apache.org/jira/browse/SAMZA-962


Repository: samza


Description
-------

Added java friendly api to KafkaSystemConsumerMetrics.
KafkaSystemConsumer metrics is done in scala and accessing this api in Java is not very intuitive.
This patch adds more straighforward Java api to this class.


Diffs
-----

  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumerMetrics.scala 741a176259b9a1cf2e5f7d64b0be98497f1c9242 

Diff: https://reviews.apache.org/r/48352/diff/


Testing
-------

manual testing.


Thanks,

Boris Shkolnik

Re: Review Request 48352: Added java friendly api to KafkaMetrics

Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48352/#review136564
-----------------------------------------------------------


Ship it!




I am assuming we won't run into problems where a metric is not registered before incrementing. :)

- Navina Ramesh


On June 7, 2016, 11:59 p.m., Boris Shkolnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48352/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 11:59 p.m.)
> 
> 
> Review request for samza and Navina Ramesh.
> 
> 
> Bugs: SAMZA-962
>     https://issues.apache.org/jira/browse/SAMZA-962
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Added java friendly api to KafkaSystemConsumerMetrics.
> KafkaSystemConsumer metrics is done in scala and accessing this api in Java is not very intuitive.
> This patch adds more straighforward Java api to this class.
> 
> 
> Diffs
> -----
> 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumerMetrics.scala 741a176259b9a1cf2e5f7d64b0be98497f1c9242 
> 
> Diff: https://reviews.apache.org/r/48352/diff/
> 
> 
> Testing
> -------
> 
> manual testing.
> 
> 
> Thanks,
> 
> Boris Shkolnik
> 
>

Re: Review Request 48352: Added java friendly api to KafkaMetrics

Posted by Boris Shkolnik <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48352/
-----------------------------------------------------------

(Updated June 7, 2016, 11:59 p.m.)


Review request for samza and Navina Ramesh.


Bugs: SAMZA-962
    https://issues.apache.org/jira/browse/SAMZA-962


Repository: samza


Description
-------

Added java friendly api to KafkaSystemConsumerMetrics.
KafkaSystemConsumer metrics is done in scala and accessing this api in Java is not very intuitive.
This patch adds more straighforward Java api to this class.


Diffs (updated)
-----

  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumerMetrics.scala 741a176259b9a1cf2e5f7d64b0be98497f1c9242 

Diff: https://reviews.apache.org/r/48352/diff/


Testing
-------

manual testing.


Thanks,

Boris Shkolnik

Re: Review Request 48352: Added java friendly api to KafkaMetrics

Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48352/#review136518
-----------------------------------------------------------


Fix it, then Ship it!




+1 !


samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumerMetrics.scala (line 58)
<https://reviews.apache.org/r/48352/#comment201582>

    Looks like you didn't provide a java api for "reconnects" metric


- Navina Ramesh


On June 7, 2016, 6:21 p.m., Boris Shkolnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48352/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 6:21 p.m.)
> 
> 
> Review request for samza and Navina Ramesh.
> 
> 
> Bugs: SAMZA-962
>     https://issues.apache.org/jira/browse/SAMZA-962
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Added java friendly api to KafkaSystemConsumerMetrics.
> KafkaSystemConsumer metrics is done in scala and accessing this api in Java is not very intuitive.
> This patch adds more straighforward Java api to this class.
> 
> 
> Diffs
> -----
> 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumerMetrics.scala 741a176259b9a1cf2e5f7d64b0be98497f1c9242 
> 
> Diff: https://reviews.apache.org/r/48352/diff/
> 
> 
> Testing
> -------
> 
> manual testing.
> 
> 
> Thanks,
> 
> Boris Shkolnik
> 
>