You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2014/05/07 13:11:02 UTC

Review Request 21155: [Windows]Integrate dependencies into MSI Windows installer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21155/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and Murali Reddy.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6563
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6563


Repository: cloudstack-git


Description
-------

Trying to add dependencies installation along with Cloud Stack installation as part of EXE. This will install needed dependencies for cloud stack like tomcat, python, cdrtools etc...


Diffs
-----

  client/pom.xml e30d97b 
  pom.xml ecae71a 
  scripts/common/keys/ssl-keys.py 4ef50b0 
  scripts/installer/windows/acs.wxs 150c472 
  scripts/installer/windows/acs_license.rtf PRE-CREATION 
  scripts/installer/windows/dependencies.wxs PRE-CREATION 

Diff: https://reviews.apache.org/r/21155/diff/


Testing
-------

These changes are specific windows files so tested on windows 2012 R2 server


Thanks,

Damodar Reddy Talakanti


Re: Review Request 21155: [Windows]Integrate dependencies into MSI Windows installer

Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21155/#review43198
-----------------------------------------------------------

Ship it!


aca7606a40adcb7c1829b05bd06725e568302d8f in master

- Murali Reddy


On May 7, 2014, 11:17 a.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21155/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 11:17 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6563
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6563
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Trying to add dependencies installation along with Cloud Stack installation as part of EXE. This will install needed dependencies for cloud stack like tomcat, python, cdrtools etc...
> 
> 
> Diffs
> -----
> 
>   client/pom.xml e30d97b 
>   pom.xml ecae71a 
>   scripts/common/keys/ssl-keys.py 4ef50b0 
>   scripts/installer/windows/acs.wxs 150c472 
>   scripts/installer/windows/acs_license.rtf PRE-CREATION 
>   scripts/installer/windows/dependencies.wxs PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21155/diff/
> 
> 
> Testing
> -------
> 
> These changes are specific windows files so tested on windows 2012 R2 server
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>


Re: Review Request 21155: [Windows]Integrate dependencies into MSI Windows installer

Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21155/#review43197
-----------------------------------------------------------

Ship it!


aca7606a40adcb7c1829b05bd06725e568302d8f in master

- Murali Reddy


On May 7, 2014, 11:17 a.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21155/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 11:17 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6563
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6563
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Trying to add dependencies installation along with Cloud Stack installation as part of EXE. This will install needed dependencies for cloud stack like tomcat, python, cdrtools etc...
> 
> 
> Diffs
> -----
> 
>   client/pom.xml e30d97b 
>   pom.xml ecae71a 
>   scripts/common/keys/ssl-keys.py 4ef50b0 
>   scripts/installer/windows/acs.wxs 150c472 
>   scripts/installer/windows/acs_license.rtf PRE-CREATION 
>   scripts/installer/windows/dependencies.wxs PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21155/diff/
> 
> 
> Testing
> -------
> 
> These changes are specific windows files so tested on windows 2012 R2 server
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>


Re: Review Request 21155: [Windows]Integrate dependencies into MSI Windows installer

Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21155/
-----------------------------------------------------------

(Updated May 7, 2014, 11:17 a.m.)


Review request for cloudstack, Abhinandan Prateek and Murali Reddy.


Changes
-------

Removed Extra spaces in couple of files


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6563
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6563


Repository: cloudstack-git


Description
-------

Trying to add dependencies installation along with Cloud Stack installation as part of EXE. This will install needed dependencies for cloud stack like tomcat, python, cdrtools etc...


Diffs (updated)
-----

  client/pom.xml e30d97b 
  pom.xml ecae71a 
  scripts/common/keys/ssl-keys.py 4ef50b0 
  scripts/installer/windows/acs.wxs 150c472 
  scripts/installer/windows/acs_license.rtf PRE-CREATION 
  scripts/installer/windows/dependencies.wxs PRE-CREATION 

Diff: https://reviews.apache.org/r/21155/diff/


Testing
-------

These changes are specific windows files so tested on windows 2012 R2 server


Thanks,

Damodar Reddy Talakanti