You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/07/10 23:12:12 UTC

[GitHub] paul-rogers commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes

paul-rogers commented on a change in pull request #1371: DRILL-6588: Make Sys tables of nullable datatypes
URL: https://github.com/apache/drill/pull/1371#discussion_r201523179
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoDataType.java
 ##########
 @@ -36,6 +36,7 @@
 
   private final List<SqlTypeName> types = Lists.newArrayList();
   private final List<String> names = Lists.newArrayList();
+  private final List<Boolean> nullables = Lists.newArrayList();
 
 Review comment:
   Again, single list of objects rather than three correlated list of primitives?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services