[jira] [Commented] (OFBIZ-2146) Quote to order - manual adjustments amount not included in cart grand total

["Deepak Dixit (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372644#comment-14372644 ] 

Deepak Dixit commented on OFBIZ-2146:
-------------------------------------

Thanks Raj for the reporting the issue.
Thanks Bilgin Ibryam and Arun Patidar for providing the patch.
Committed in :
Trunk at r#1668214
R14.12 at r#1668224
R13.07 at r#1668225
R12.04 at r#1668227

> Quote to order - manual adjustments amount not included in cart grand total
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-2146
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2146
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Trunk
>         Environment: Ubuntu 8.10, Firefox 3.0.5Quote to order - manual adjustments amount not included in cart grand total
>            Reporter: Raj Saini
>            Assignee: Deepak Dixit
>         Attachments: OFBIZ-2146.patch, order.diff
>
>
> While creating a order from a quote with a manual adjustment of shipping charges, the adjustment amount is not included in the cart grand total. Although manual adjustments are copied to order adjustment and added to cart adjustment (ShoppingCartService.java, lines 676-781), they are filtered out while calculating the maxAmount for OrderPaymentPreference when calling the cart.getOrderOtherAdjustmentTotal() method which in turns calls the OrderReadHelper.calcOrderAdjustments(List orderHeaderAdjustments, BigDecimal subTotal, boolean includeOther, boolean includeTax, boolean includeShipping). This method filters out the SHIPPING_CHARGES order adjustment as includeShipping parameter is always true.
> One way to solve the problem is to use the value of includeInShipping field from OrderAdjsutment entity in  OrderHelper#filterOrderAdjustments(List adjustments, boolean includeOther, boolean includeTax, boolean includeShipping, boolean forTax, boolean forShipping) method and setting this to true in QuoteAdjustment entity. (quote adjustments are copied to order adjustment by loadCartFromQuote service). However, doing so wrongly shows the shipping charges twice in the Order view and also add the shipping charges to the total tax whereas the grand total remains correct. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)