[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #19386: [1.x] Move block.optimize_for backend_opts to kwargs

[GitBox <gi...@apache.org>]

samskalicky commented on a change in pull request #19386:
URL: https://github.com/apache/incubator-mxnet/pull/19386#discussion_r517067994



##########
File path: python/mxnet/gluon/block.py
##########
@@ -1059,7 +1059,7 @@ def _call_cached_op(self, *args):
             out = [out]
         return _regroup(out, self._out_format)
 
-    def optimize_for(self, x, *args, backend=None, backend_opts=None, clear=True, **kwargs):
+    def optimize_for(self, x, *args, backend=None, clear=True, static_alloc=False, static_shape=False, **kwargs):

Review comment:
       I like this, can we do the same for hybridize and eliminate backend_opts altogether?
   Change:
   ```
       def hybridize(self, active=True, backend=None, backend_opts=None, clear=True, **kwargs):
   ```
   To:
   ```
       def hybridize(self, active=True, backend=None, clear=True, static_alloc=False, static_shape=False, **kwargs):
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org