Re: [DISCUSS] KIP-697: Stricter parsing of addresses in configs

[Tom Bentley <tb...@redhat.com>]

So we missed the boat for 2.8. Any interest in doing this is 3.0 (even just
adding the warning?)

Kind regards,

Tom

On Tue, Jan 19, 2021 at 12:09 PM Tom Bentley <tb...@redhat.com> wrote:

> Hi Gwen,
>
> Thanks for taking the time to look at it.
>
> 1. It's difficult to have a clear idea how often people supply a protocol.
> I wouldn't expect it to be common, since the documentation doesn't mention
> it. Maybe early users of Kafka still have the protocol in their configs
> (assuming it was documented differently at some point, or maybe even used,
> though I did a bit of digging and didn't find anything). I agree that the
> benefits are small but the bug mentioned in the KIP is quite nasty, so I
> feel it would be good to tidy this up.
>
> 2. In the light of 1. I think some logging in 2.8 would be a great idea.
> I've opened a PR[1] which could be merged if this KIP is accepted.
>
> Is this enough to alleviate your concerns?
>
> Kind regards,
>
> Tom
>
> [1]: https://github.com/apache/kafka/pull/9929
>
> On Thu, Jan 14, 2021 at 9:37 PM Gwen Shapira <gw...@confluent.io> wrote:
>
>> Sorry for being late, I just saw this. I have a concern about the
>> compatibility story:
>>
>> 1. Do we know how common use of protocol is? While this is an
>> improvement, the benefits are a bit small (IMO) and if this will break
>> a large number of installations (or will make the upgrade to 3.0 more
>> painful and therefore less likely to happen) - maybe it is't worth it.
>> 2. Should we add a PR to 2.8 that will print deprecation warnings if
>> protocol is used? This way people will at least know what is coming.
>>
>> Gwen
>>
>> On Mon, Jan 4, 2021 at 1:21 AM Tom Bentley <tb...@redhat.com> wrote:
>> >
>> > Hi,
>> >
>> > If there are no comments about this minor change in the next day or two
>> I
>> > will start a vote.
>> >
>> > Kind regards,
>> >
>> > Tom
>> >
>> > On Wed, Dec 9, 2020 at 6:10 PM Tom Bentley <tb...@redhat.com> wrote:
>> >
>> > > Hi,
>> > >
>> > > I'd like to start a discussion on a small KIP which proposes stricter
>> > > parsing of host:port addresses in various configs for Kafka 3.0:
>> > >
>> > >
>> > >
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-697%3A+Stricter+parsing+of+addresses+in+configs
>> > >
>> > > I'd be grateful for any feedback people may have.
>> > >
>> > > Kind regards,
>> > >
>> > > Tom
>> > >
>>
>>
>>
>> --
>> Gwen Shapira
>> Engineering Manager | Confluent
>> 650.450.2760 | @gwenshap
>> Follow us: Twitter | blog
>>
>>