You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by kk...@apache.org on 2020/03/28 23:38:49 UTC
[kafka] branch trunk updated: MINOR: Add missing @Override
annotation and simplify Thread declarations with lambdas (#8363)
This is an automated email from the ASF dual-hosted git repository.
kkarantasis pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 68ac551 MINOR: Add missing @Override annotation and simplify Thread declarations with lambdas (#8363)
68ac551 is described below
commit 68ac551966e2be5b13adb2f703a01211e6f7a34b
Author: 17hao <sq...@gmail.com>
AuthorDate: Sun Mar 29 07:38:12 2020 +0800
MINOR: Add missing @Override annotation and simplify Thread declarations with lambdas (#8363)
Add missing @Override annotations and use lambdas when declaring threads to suppress warnings in IDEs and improve readability.
Reviewers: Ron Dagostino <rd...@confluent.io>, Konstantine Karantasis <ko...@confluent.io>
---
.../kafka/clients/consumer/KafkaConsumer.java | 1 +
.../kafka/clients/producer/internals/Sender.java | 1 +
.../org/apache/kafka/common/metrics/Metrics.java | 1 +
.../clients/producer/internals/BufferPoolTest.java | 45 ++++++++++------------
.../apache/kafka/common/metrics/MetricsTest.java | 1 +
.../apache/kafka/common/network/NioEchoServer.java | 1 +
6 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java b/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
index 76d0576..5b0a8c7 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
@@ -478,6 +478,7 @@ import static org.apache.kafka.clients.consumer.internals.PartitionAssignorAdapt
* this.consumer = consumer;
* }
*
+ * {@literal}@Override
* public void run() {
* try {
* consumer.subscribe(Arrays.asList("topic"));
diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java b/clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
index a35dcd3..a9b9fe9 100644
--- a/clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
+++ b/clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
@@ -230,6 +230,7 @@ public class Sender implements Runnable {
/**
* The main run loop for the sender thread
*/
+ @Override
public void run() {
log.debug("Starting Kafka producer I/O thread.");
diff --git a/clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java b/clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java
index 7f00adf..dee970c 100644
--- a/clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java
+++ b/clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java
@@ -579,6 +579,7 @@ public class Metrics implements Closeable {
* Package private for testing
*/
class ExpireSensorTask implements Runnable {
+ @Override
public void run() {
for (Map.Entry<String, Sensor> sensorEntry : sensors.entrySet()) {
// removeSensor also locks the sensor object. This is fine because synchronized is reentrant
diff --git a/clients/src/test/java/org/apache/kafka/clients/producer/internals/BufferPoolTest.java b/clients/src/test/java/org/apache/kafka/clients/producer/internals/BufferPoolTest.java
index 724d9d4..9eee284 100644
--- a/clients/src/test/java/org/apache/kafka/clients/producer/internals/BufferPoolTest.java
+++ b/clients/src/test/java/org/apache/kafka/clients/producer/internals/BufferPoolTest.java
@@ -116,43 +116,37 @@ public class BufferPoolTest {
private CountDownLatch asyncDeallocate(final BufferPool pool, final ByteBuffer buffer) {
final CountDownLatch latch = new CountDownLatch(1);
- Thread thread = new Thread() {
- public void run() {
- try {
- latch.await();
- } catch (InterruptedException e) {
- e.printStackTrace();
- }
- pool.deallocate(buffer);
+ Thread thread = new Thread(() -> {
+ try {
+ latch.await();
+ } catch (InterruptedException e) {
+ e.printStackTrace();
}
- };
+ pool.deallocate(buffer);
+ });
thread.start();
return latch;
}
private void delayedDeallocate(final BufferPool pool, final ByteBuffer buffer, final long delayMs) {
- Thread thread = new Thread() {
- public void run() {
- Time.SYSTEM.sleep(delayMs);
- pool.deallocate(buffer);
- }
- };
+ Thread thread = new Thread(() -> {
+ Time.SYSTEM.sleep(delayMs);
+ pool.deallocate(buffer);
+ });
thread.start();
}
private CountDownLatch asyncAllocate(final BufferPool pool, final int size) {
final CountDownLatch completed = new CountDownLatch(1);
- Thread thread = new Thread() {
- public void run() {
- try {
- pool.allocate(size, maxBlockTimeMs);
- } catch (InterruptedException e) {
- e.printStackTrace();
- } finally {
- completed.countDown();
- }
+ Thread thread = new Thread(() -> {
+ try {
+ pool.allocate(size, maxBlockTimeMs);
+ } catch (InterruptedException e) {
+ e.printStackTrace();
+ } finally {
+ completed.countDown();
}
- };
+ });
thread.start();
return completed;
}
@@ -362,6 +356,7 @@ public class BufferPoolTest {
this.pool = pool;
}
+ @Override
public void run() {
try {
for (int i = 0; i < iterations; i++) {
diff --git a/clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java b/clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java
index 0357045..a6f5d41 100644
--- a/clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java
+++ b/clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java
@@ -770,6 +770,7 @@ public class MetricsTest {
this.opName = opName;
this.op = op;
}
+ @Override
public void run() {
try {
while (alive.get()) {
diff --git a/clients/src/test/java/org/apache/kafka/common/network/NioEchoServer.java b/clients/src/test/java/org/apache/kafka/common/network/NioEchoServer.java
index 36ac1ed..d69b184 100644
--- a/clients/src/test/java/org/apache/kafka/common/network/NioEchoServer.java
+++ b/clients/src/test/java/org/apache/kafka/common/network/NioEchoServer.java
@@ -319,6 +319,7 @@ public class NioEchoServer extends Thread {
public AcceptorThread() throws IOException {
setName("acceptor");
}
+ @Override
public void run() {
try {
java.nio.channels.Selector acceptSelector = java.nio.channels.Selector.open();