You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2009/08/07 18:07:14 UTC

[jira] Created: (JCR-2248) QValueFactoryImpl$BinaryQValue must not return 'this' on getBinary

QValueFactoryImpl$BinaryQValue must not return 'this' on getBinary
------------------------------------------------------------------

                 Key: JCR-2248
                 URL: https://issues.apache.org/jira/browse/JCR-2248
             Project: Jackrabbit Content Repository
          Issue Type: Bug
          Components: jackrabbit-spi-commons
            Reporter: Marcel Reutegger
            Priority: Minor


This is basically the same as JCR-2238, but for the spi-commons module. BinaryQValue returns 'this' on getBinary(), which will lead to a file not found exception because Binary.dispose() will delete the the underlying temp file.

The issue is partially hidden by the presence of a bug in BinaryQValue.read(): the RandomAccessFile is not closed after reading, which might prevent deleting of the temp file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-2248) QValueFactoryImpl$BinaryQValue must not return 'this' on getBinary

Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger resolved JCR-2248.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0

Applied patch in revision: 802718

> QValueFactoryImpl$BinaryQValue must not return 'this' on getBinary
> ------------------------------------------------------------------
>
>                 Key: JCR-2248
>                 URL: https://issues.apache.org/jira/browse/JCR-2248
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi-commons
>            Reporter: Marcel Reutegger
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: JCR-2248.patch
>
>
> This is basically the same as JCR-2238, but for the spi-commons module. BinaryQValue returns 'this' on getBinary(), which will lead to a file not found exception because Binary.dispose() will delete the the underlying temp file.
> The issue is partially hidden by the presence of a bug in BinaryQValue.read(): the RandomAccessFile is not closed after reading, which might prevent deleting of the temp file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-2248) QValueFactoryImpl$BinaryQValue must not return 'this' on getBinary

Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger updated JCR-2248:
----------------------------------

    Attachment: JCR-2248.patch

Proposed changes.

> QValueFactoryImpl$BinaryQValue must not return 'this' on getBinary
> ------------------------------------------------------------------
>
>                 Key: JCR-2248
>                 URL: https://issues.apache.org/jira/browse/JCR-2248
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi-commons
>            Reporter: Marcel Reutegger
>            Priority: Minor
>         Attachments: JCR-2248.patch
>
>
> This is basically the same as JCR-2238, but for the spi-commons module. BinaryQValue returns 'this' on getBinary(), which will lead to a file not found exception because Binary.dispose() will delete the the underlying temp file.
> The issue is partially hidden by the presence of a bug in BinaryQValue.read(): the RandomAccessFile is not closed after reading, which might prevent deleting of the temp file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.