You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/07/27 07:32:54 UTC

[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1307: tools/hci_throughput: Custom transport option

sjanc commented on code in PR #1307:
URL: https://github.com/apache/mynewt-nimble/pull/1307#discussion_r930716867


##########
tools/hci_throughput/transport_factory.py:
##########
@@ -18,15 +18,31 @@
 #
 
 import hci_socket
+import logging
+import traceback
+import sys
 
 class TransportFactory:
-	def __init__(self, device_index=None, device_mode=None,
-                 asyncio_loop=None) -> None:
-		if (type(device_index) == int or device_index.isnumeric()):
+	def __init__(self, device_index: str = None, device_mode=None,

Review Comment:
   something is wrong with whitespaces in this code block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org