[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5177: Lucene DocId to PinotDocId cache

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #5177: Lucene DocId to PinotDocId cache
URL: https://github.com/apache/incubator-pinot/pull/5177#discussion_r400346677
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/text/LuceneTextIndexReader.java
 ##########
 @@ -148,8 +153,12 @@ private MutableRoaringBitmap getPinotDocIds(MutableRoaringBitmap luceneDocIds) {
     try {
       while (luceneDocIDIterator.hasNext()) {
         int luceneDocId = luceneDocIDIterator.next();
-        Document document = _indexSearcher.doc(luceneDocId);
-        int pinotDocId = Integer.valueOf(document.get(LuceneTextIndexCreator.LUCENE_INDEX_DOC_ID_COLUMN_NAME));
+        Integer pinotDocId = _luceneDocIDToPinotDocIDCache.get(luceneDocId);
 
 Review comment:
   I am not using this method anymore. The mapping is built once during segment load and memory mapped.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org