You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/02 21:16:31 UTC

[GitHub] [tvm] driazati commented on a change in pull request #9534: Add `make docs` and doc building instructions

driazati commented on a change in pull request #9534:
URL: https://github.com/apache/tvm/pull/9534#discussion_r759761214



##########
File path: docs/requirements.txt
##########
@@ -0,0 +1,11 @@
+autodocsumm==0.2.7

Review comment:
       Removed the requirements.txt and added 2 building flows, one that uses a short script and relies on ci-gpu and one that just uses it to generate the list of dependencies. Given that creating a list is pretty simple and anyone developing the docs probably has access to Docker I think it's fine to not commit the dependencies list for now and let people generate it directly.
   
   ~~For now this works OK but the makefile + bash setup doesn't seem tenable for the larger goals of allowing developers to reproduce CI easily, we might want to consider a Python runner similar to Rust's [`x.py`](https://github.com/rust-lang/rust/tree/master/src/bootstrap)~~ added a Python runner instead




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org