You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/02 01:38:17 UTC
[GitHub] [arrow] cyb70289 opened a new pull request #10433: ARROW-12911: [Python] Export scalar aggregate options to pc.sum
cyb70289 opened a new pull request #10433:
URL: https://github.com/apache/arrow/pull/10433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a change in pull request #10433: ARROW-12911: [Python] Export scalar aggregate options to pc.sum
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #10433:
URL: https://github.com/apache/arrow/pull/10433#discussion_r644441978
##########
File path: python/pyarrow/array.pxi
##########
@@ -836,12 +836,6 @@ cdef class Array(_PandasConvertible):
result = GetResultValue(self.ap.View(type.sp_type))
return pyarrow_wrap_array(result)
- def sum(self):
Review comment:
Added kwargs to array.sum(). Tested array.sum(min_count=0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a change in pull request #10433: ARROW-12911: [Python] Export scalar aggregate options to pc.sum
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #10433:
URL: https://github.com/apache/arrow/pull/10433#discussion_r644441978
##########
File path: python/pyarrow/array.pxi
##########
@@ -836,12 +836,6 @@ cdef class Array(_PandasConvertible):
result = GetResultValue(self.ap.View(type.sp_type))
return pyarrow_wrap_array(result)
- def sum(self):
Review comment:
Added kwargs to array.sum(). Tested array.sum(min_count=0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10433: ARROW-12911: [Python] Export scalar aggregate options to pc.sum
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10433:
URL: https://github.com/apache/arrow/pull/10433#issuecomment-852644263
https://issues.apache.org/jira/browse/ARROW-12911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche closed pull request #10433: ARROW-12911: [Python] Export scalar aggregate options to pc.sum
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #10433:
URL: https://github.com/apache/arrow/pull/10433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #10433: ARROW-12911: [Python] Export scalar aggregate options to pc.sum
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #10433:
URL: https://github.com/apache/arrow/pull/10433#discussion_r644304393
##########
File path: python/pyarrow/array.pxi
##########
@@ -836,12 +836,6 @@ cdef class Array(_PandasConvertible):
result = GetResultValue(self.ap.View(type.sp_type))
return pyarrow_wrap_array(result)
- def sum(self):
Review comment:
Actually removing this method is a backwards incompatible change. If we want to do that, I think we should deprecate it first (although it is certainly strange to only have a single reduction method exposed here)
For now I would maybe just pass through ``**kwargs`` (or leave as as)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #10433: ARROW-12911: [Python] Export scalar aggregate options to pc.sum
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #10433:
URL: https://github.com/apache/arrow/pull/10433#issuecomment-854570285
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a change in pull request #10433: ARROW-12911: [Python] Export scalar aggregate options to pc.sum
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #10433:
URL: https://github.com/apache/arrow/pull/10433#discussion_r643811727
##########
File path: python/pyarrow/array.pxi
##########
@@ -836,12 +836,6 @@ cdef class Array(_PandasConvertible):
result = GetResultValue(self.ap.View(type.sp_type))
return pyarrow_wrap_array(result)
- def sum(self):
Review comment:
Remove this `sum`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org