You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Daniel Krieg (JIRA)" <ji...@apache.org> on 2006/12/13 20:47:23 UTC
[jira] Created: (PLUTO-278) Create module pluto-taglib-el
Create module pluto-taglib-el
-----------------------------
Key: PLUTO-278
URL: http://issues.apache.org/jira/browse/PLUTO-278
Project: Pluto
Issue Type: Improvement
Components: portlet container taglibs
Affects Versions: Current CVS
Reporter: Daniel Krieg
Priority: Critical
We must separate EL tags that link against JSP 2.0 from those that do not. The EL version of ParamTag currently in SVN is requiring JSP 2.0 JARs thus making the entire module unusable in a JSP 1.2 environment like Weblogic 8.1. Creating a separate module for the EL tags is therefore manditory. I have created and submitted a patch that will make necessary changes to use the pluto-taglib-1.1.0-SNAPSHOT.jar usable in Weblogic 8.1.5. We may want to also consider 2 versions of the pluto-taglib-el modules, one that links against JSP 2.0 and another agains jstl-1.0 and standard-1.0 jars for use in JSP 1.2 environments.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PLUTO-278) Create module pluto-taglib-el
Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/PLUTO-278?page=all ]
David DeWolf updated PLUTO-278:
-------------------------------
Fix Version/s: 1.1.1
> Create module pluto-taglib-el
> -----------------------------
>
> Key: PLUTO-278
> URL: http://issues.apache.org/jira/browse/PLUTO-278
> Project: Pluto
> Issue Type: Improvement
> Components: portlet container taglibs
> Affects Versions: Current CVS
> Reporter: Daniel Krieg
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: pluto-1.1.0-taglib-el.diff
>
>
> We must separate EL tags that link against JSP 2.0 from those that do not. The EL version of ParamTag currently in SVN is requiring JSP 2.0 JARs thus making the entire module unusable in a JSP 1.2 environment like Weblogic 8.1. Creating a separate module for the EL tags is therefore manditory. I have created and submitted a patch that will make necessary changes to use the pluto-taglib-1.1.0-SNAPSHOT.jar usable in Weblogic 8.1.5. We may want to also consider 2 versions of the pluto-taglib-el modules, one that links against JSP 2.0 and another agains jstl-1.0 and standard-1.0 jars for use in JSP 1.2 environments.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (PLUTO-278) Create module pluto-taglib-el
Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David DeWolf reassigned PLUTO-278:
----------------------------------
Assignee: David DeWolf
> Create module pluto-taglib-el
> -----------------------------
>
> Key: PLUTO-278
> URL: https://issues.apache.org/jira/browse/PLUTO-278
> Project: Pluto
> Issue Type: Improvement
> Components: portlet container taglibs
> Affects Versions: Current CVS
> Reporter: Daniel Krieg
> Assigned To: David DeWolf
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: pluto-1.1.0-taglib-el.diff, pluto-1.1.0-taglib-el.diff, pluto-taglib-el.tar.gz
>
>
> We must separate EL tags that link against JSP 2.0 from those that do not. The EL version of ParamTag currently in SVN is requiring JSP 2.0 JARs thus making the entire module unusable in a JSP 1.2 environment like Weblogic 8.1. Creating a separate module for the EL tags is therefore manditory. I have created and submitted a patch that will make necessary changes to use the pluto-taglib-1.1.0-SNAPSHOT.jar usable in Weblogic 8.1.5. We may want to also consider 2 versions of the pluto-taglib-el modules, one that links against JSP 2.0 and another agains jstl-1.0 and standard-1.0 jars for use in JSP 1.2 environments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-278) Create module pluto-taglib-el
Posted by "Daniel Krieg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/PLUTO-278?page=comments#action_12458474 ]
Daniel Krieg commented on PLUTO-278:
------------------------------------
All this patch does is pull out EL tags from the pluto-taglib module and places them in a new module pluto-taglib-el. I do like your suggestion regarding the use of reflection, very nice! I will reproduce the patches without the absolute path and resubmitt.
> Create module pluto-taglib-el
> -----------------------------
>
> Key: PLUTO-278
> URL: http://issues.apache.org/jira/browse/PLUTO-278
> Project: Pluto
> Issue Type: Improvement
> Components: portlet container taglibs
> Affects Versions: Current CVS
> Reporter: Daniel Krieg
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: pluto-1.1.0-taglib-el.diff
>
>
> We must separate EL tags that link against JSP 2.0 from those that do not. The EL version of ParamTag currently in SVN is requiring JSP 2.0 JARs thus making the entire module unusable in a JSP 1.2 environment like Weblogic 8.1. Creating a separate module for the EL tags is therefore manditory. I have created and submitted a patch that will make necessary changes to use the pluto-taglib-1.1.0-SNAPSHOT.jar usable in Weblogic 8.1.5. We may want to also consider 2 versions of the pluto-taglib-el modules, one that links against JSP 2.0 and another agains jstl-1.0 and standard-1.0 jars for use in JSP 1.2 environments.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PLUTO-278) Create module pluto-taglib-el
Posted by "Daniel Krieg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/PLUTO-278?page=comments#action_12458480 ]
Daniel Krieg commented on PLUTO-278:
------------------------------------
BTW, the patch can be applied as follows:
patch -p7 < pluto-1.1.0-taglib-el.diff
> Create module pluto-taglib-el
> -----------------------------
>
> Key: PLUTO-278
> URL: http://issues.apache.org/jira/browse/PLUTO-278
> Project: Pluto
> Issue Type: Improvement
> Components: portlet container taglibs
> Affects Versions: Current CVS
> Reporter: Daniel Krieg
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: pluto-1.1.0-taglib-el.diff
>
>
> We must separate EL tags that link against JSP 2.0 from those that do not. The EL version of ParamTag currently in SVN is requiring JSP 2.0 JARs thus making the entire module unusable in a JSP 1.2 environment like Weblogic 8.1. Creating a separate module for the EL tags is therefore manditory. I have created and submitted a patch that will make necessary changes to use the pluto-taglib-1.1.0-SNAPSHOT.jar usable in Weblogic 8.1.5. We may want to also consider 2 versions of the pluto-taglib-el modules, one that links against JSP 2.0 and another agains jstl-1.0 and standard-1.0 jars for use in JSP 1.2 environments.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PLUTO-278) Create module pluto-taglib-el
Posted by "Daniel Krieg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/PLUTO-278?page=all ]
Daniel Krieg updated PLUTO-278:
-------------------------------
Attachment: pluto-1.1.0-taglib-el.diff
Here is a revised patch that simply moves the EL ParamTag and portlet-el.tld files into the pluto-taglib-el module that I am submitting in a tar.gz file.
> Create module pluto-taglib-el
> -----------------------------
>
> Key: PLUTO-278
> URL: http://issues.apache.org/jira/browse/PLUTO-278
> Project: Pluto
> Issue Type: Improvement
> Components: portlet container taglibs
> Affects Versions: Current CVS
> Reporter: Daniel Krieg
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: pluto-1.1.0-taglib-el.diff, pluto-1.1.0-taglib-el.diff
>
>
> We must separate EL tags that link against JSP 2.0 from those that do not. The EL version of ParamTag currently in SVN is requiring JSP 2.0 JARs thus making the entire module unusable in a JSP 1.2 environment like Weblogic 8.1. Creating a separate module for the EL tags is therefore manditory. I have created and submitted a patch that will make necessary changes to use the pluto-taglib-1.1.0-SNAPSHOT.jar usable in Weblogic 8.1.5. We may want to also consider 2 versions of the pluto-taglib-el modules, one that links against JSP 2.0 and another agains jstl-1.0 and standard-1.0 jars for use in JSP 1.2 environments.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (PLUTO-278) Create module pluto-taglib-el
Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David DeWolf resolved PLUTO-278.
--------------------------------
Resolution: Fixed
I now use an abstract factory to retrieve a evaluator proxy which can handle the specific environment in which it is deployed. Reflection is used to determine support. Add apache taglib standard jars to the classpath for support in < 2.0 containers. 2.1 is not yet support (ELContext), but should be planned at sometime in 1.2.x.
> Create module pluto-taglib-el
> -----------------------------
>
> Key: PLUTO-278
> URL: https://issues.apache.org/jira/browse/PLUTO-278
> Project: Pluto
> Issue Type: Improvement
> Components: portlet container taglibs
> Affects Versions: unspecified
> Reporter: Daniel Krieg
> Assigned To: David DeWolf
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: pluto-1.1.0-taglib-el.diff, pluto-1.1.0-taglib-el.diff, pluto-taglib-el.tar.gz
>
>
> We must separate EL tags that link against JSP 2.0 from those that do not. The EL version of ParamTag currently in SVN is requiring JSP 2.0 JARs thus making the entire module unusable in a JSP 1.2 environment like Weblogic 8.1. Creating a separate module for the EL tags is therefore manditory. I have created and submitted a patch that will make necessary changes to use the pluto-taglib-1.1.0-SNAPSHOT.jar usable in Weblogic 8.1.5. We may want to also consider 2 versions of the pluto-taglib-el modules, one that links against JSP 2.0 and another agains jstl-1.0 and standard-1.0 jars for use in JSP 1.2 environments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-278) Create module pluto-taglib-el
Posted by "Daniel Krieg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/PLUTO-278?page=comments#action_12458489 ]
Daniel Krieg commented on PLUTO-278:
------------------------------------
sorry, should be:
path -p6 < pluto-1.1.0-taglib-el.diff
> Create module pluto-taglib-el
> -----------------------------
>
> Key: PLUTO-278
> URL: http://issues.apache.org/jira/browse/PLUTO-278
> Project: Pluto
> Issue Type: Improvement
> Components: portlet container taglibs
> Affects Versions: Current CVS
> Reporter: Daniel Krieg
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: pluto-1.1.0-taglib-el.diff
>
>
> We must separate EL tags that link against JSP 2.0 from those that do not. The EL version of ParamTag currently in SVN is requiring JSP 2.0 JARs thus making the entire module unusable in a JSP 1.2 environment like Weblogic 8.1. Creating a separate module for the EL tags is therefore manditory. I have created and submitted a patch that will make necessary changes to use the pluto-taglib-1.1.0-SNAPSHOT.jar usable in Weblogic 8.1.5. We may want to also consider 2 versions of the pluto-taglib-el modules, one that links against JSP 2.0 and another agains jstl-1.0 and standard-1.0 jars for use in JSP 1.2 environments.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PLUTO-278) Create module pluto-taglib-el
Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477720 ]
David DeWolf commented on PLUTO-278:
------------------------------------
Please give this a test and see if it meets your bill. I haven't tested in a 1.2 container.
> Create module pluto-taglib-el
> -----------------------------
>
> Key: PLUTO-278
> URL: https://issues.apache.org/jira/browse/PLUTO-278
> Project: Pluto
> Issue Type: Improvement
> Components: portlet container taglibs
> Affects Versions: unspecified
> Reporter: Daniel Krieg
> Assigned To: David DeWolf
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: pluto-1.1.0-taglib-el.diff, pluto-1.1.0-taglib-el.diff, pluto-taglib-el.tar.gz
>
>
> We must separate EL tags that link against JSP 2.0 from those that do not. The EL version of ParamTag currently in SVN is requiring JSP 2.0 JARs thus making the entire module unusable in a JSP 1.2 environment like Weblogic 8.1. Creating a separate module for the EL tags is therefore manditory. I have created and submitted a patch that will make necessary changes to use the pluto-taglib-1.1.0-SNAPSHOT.jar usable in Weblogic 8.1.5. We may want to also consider 2 versions of the pluto-taglib-el modules, one that links against JSP 2.0 and another agains jstl-1.0 and standard-1.0 jars for use in JSP 1.2 environments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-278) Create module pluto-taglib-el
Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477703 ]
David DeWolf commented on PLUTO-278:
------------------------------------
I'm still not sold on a seperate module so I'm taking a look into the reflection approach. Expect something to be committed soon.
> Create module pluto-taglib-el
> -----------------------------
>
> Key: PLUTO-278
> URL: https://issues.apache.org/jira/browse/PLUTO-278
> Project: Pluto
> Issue Type: Improvement
> Components: portlet container taglibs
> Affects Versions: unspecified
> Reporter: Daniel Krieg
> Assigned To: David DeWolf
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: pluto-1.1.0-taglib-el.diff, pluto-1.1.0-taglib-el.diff, pluto-taglib-el.tar.gz
>
>
> We must separate EL tags that link against JSP 2.0 from those that do not. The EL version of ParamTag currently in SVN is requiring JSP 2.0 JARs thus making the entire module unusable in a JSP 1.2 environment like Weblogic 8.1. Creating a separate module for the EL tags is therefore manditory. I have created and submitted a patch that will make necessary changes to use the pluto-taglib-1.1.0-SNAPSHOT.jar usable in Weblogic 8.1.5. We may want to also consider 2 versions of the pluto-taglib-el modules, one that links against JSP 2.0 and another agains jstl-1.0 and standard-1.0 jars for use in JSP 1.2 environments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-278) Create module pluto-taglib-el
Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/PLUTO-278?page=comments#action_12458339 ]
David DeWolf commented on PLUTO-278:
------------------------------------
I haven't looked at the patch (except to see that it includes absolute paths and thus will be a pain to apply), but I really don't want to duplicate the tags themselves if that's what you're suggesting. I'd much rather use reflection to determine which ExpressionEvaluator (jsp2.0 or standard) we should use so it just works in the target environment. The idea is a good one though - we should definitely support 1.2.
> Create module pluto-taglib-el
> -----------------------------
>
> Key: PLUTO-278
> URL: http://issues.apache.org/jira/browse/PLUTO-278
> Project: Pluto
> Issue Type: Improvement
> Components: portlet container taglibs
> Affects Versions: Current CVS
> Reporter: Daniel Krieg
> Priority: Critical
> Attachments: pluto-1.1.0-taglib-el.diff
>
>
> We must separate EL tags that link against JSP 2.0 from those that do not. The EL version of ParamTag currently in SVN is requiring JSP 2.0 JARs thus making the entire module unusable in a JSP 1.2 environment like Weblogic 8.1. Creating a separate module for the EL tags is therefore manditory. I have created and submitted a patch that will make necessary changes to use the pluto-taglib-1.1.0-SNAPSHOT.jar usable in Weblogic 8.1.5. We may want to also consider 2 versions of the pluto-taglib-el modules, one that links against JSP 2.0 and another agains jstl-1.0 and standard-1.0 jars for use in JSP 1.2 environments.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PLUTO-278) Create module pluto-taglib-el
Posted by "Daniel Krieg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/PLUTO-278?page=all ]
Daniel Krieg updated PLUTO-278:
-------------------------------
Attachment: pluto-taglib-el.tar.gz
This set of sources creates the new pluto-taglib-el module that contains the ParamTag.java and portlet-el.tld files originally found in the pluto-taglib module.
> Create module pluto-taglib-el
> -----------------------------
>
> Key: PLUTO-278
> URL: http://issues.apache.org/jira/browse/PLUTO-278
> Project: Pluto
> Issue Type: Improvement
> Components: portlet container taglibs
> Affects Versions: Current CVS
> Reporter: Daniel Krieg
> Priority: Critical
> Fix For: 1.1.1
>
> Attachments: pluto-1.1.0-taglib-el.diff, pluto-1.1.0-taglib-el.diff, pluto-taglib-el.tar.gz
>
>
> We must separate EL tags that link against JSP 2.0 from those that do not. The EL version of ParamTag currently in SVN is requiring JSP 2.0 JARs thus making the entire module unusable in a JSP 1.2 environment like Weblogic 8.1. Creating a separate module for the EL tags is therefore manditory. I have created and submitted a patch that will make necessary changes to use the pluto-taglib-1.1.0-SNAPSHOT.jar usable in Weblogic 8.1.5. We may want to also consider 2 versions of the pluto-taglib-el modules, one that links against JSP 2.0 and another agains jstl-1.0 and standard-1.0 jars for use in JSP 1.2 environments.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PLUTO-278) Create module pluto-taglib-el
Posted by "Daniel Krieg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/PLUTO-278?page=all ]
Daniel Krieg updated PLUTO-278:
-------------------------------
Attachment: pluto-1.1.0-taglib-el.diff
This patch moves the EL ParamTag into a separate module and modifies the pom.xml files to correctly resolve dependecies, etc.
> Create module pluto-taglib-el
> -----------------------------
>
> Key: PLUTO-278
> URL: http://issues.apache.org/jira/browse/PLUTO-278
> Project: Pluto
> Issue Type: Improvement
> Components: portlet container taglibs
> Affects Versions: Current CVS
> Reporter: Daniel Krieg
> Priority: Critical
> Attachments: pluto-1.1.0-taglib-el.diff
>
>
> We must separate EL tags that link against JSP 2.0 from those that do not. The EL version of ParamTag currently in SVN is requiring JSP 2.0 JARs thus making the entire module unusable in a JSP 1.2 environment like Weblogic 8.1. Creating a separate module for the EL tags is therefore manditory. I have created and submitted a patch that will make necessary changes to use the pluto-taglib-1.1.0-SNAPSHOT.jar usable in Weblogic 8.1.5. We may want to also consider 2 versions of the pluto-taglib-el modules, one that links against JSP 2.0 and another agains jstl-1.0 and standard-1.0 jars for use in JSP 1.2 environments.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira