[GitHub] [shiro] bdemers commented on a change in pull request #278: (build) fix JDK 16/17 builds

[GitBox <gi...@apache.org>]

bdemers commented on a change in pull request #278:
URL: https://github.com/apache/shiro/pull/278#discussion_r555312818



##########
File path: pom.xml
##########
@@ -70,6 +70,10 @@
         <!-- Replaced by the build number plugin at build time: -->
         <buildNumber>${user.name}-${maven.build.timestamp}</buildNumber>
         <jacoco.skip>true</jacoco.skip>
+        <!--suppress CheckTagEmptyBody -->
+        <surefire.argLine></surefire.argLine>

Review comment:
       I'm guessing this works, but (if you haven't already) double-check to make sure the code coverage works (Jacoco sets the `argLine` prop too)

##########
File path: integration-tests/guice3/pom.xml
##########
@@ -123,4 +123,16 @@
         </dependency>
 	</dependencies>
 
+	<profiles>
+		<profile>
+			<id>jdk16</id>
+			<activation>
+				<jdk>[16,)</jdk>
+			</activation>
+			<properties>
+				<surefire.argLine>--illegal-access=permit</surefire.argLine>

Review comment:
       nit: add a comment as to why this is needed (to give us a hint when to remove it in the future)

##########
File path: pom.xml
##########
@@ -1400,6 +1414,12 @@
                 </pluginManagement>
             </build>
         </profile>
+        <profile>
+            <id>jdk16</id>
+            <activation>
+                <jdk>[16,)</jdk>
+            </activation>
+        </profile>

Review comment:
       delete the empty profile block?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org