You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/07 05:22:41 UTC
[GitHub] john-bodley opened a new pull request #5155: [migrations] Cleanup
recent migrations
john-bodley opened a new pull request #5155: [migrations] Cleanup recent migrations
URL: https://github.com/apache/incubator-superset/pull/5155
This PR cleans up a couple of issues with some recent migrations:
1. For `c5756bec8b47` it removes unnecessary definitions.
2. For `130915240929` it removes the unnecessary `merge` for each record which significantly impacts performance. The `session.commit()` is all that is required to commit the mutated `tbl` objects which is a similar pattern to `c5756bec8b47`.
to: @michellethomas @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org