You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/12/25 00:47:14 UTC

[GitHub] jonnxu commented on a change in pull request #34: [issue-33] CPullConsumer cannot pull message because of pullResult without nextBeginOffset

jonnxu commented on a change in pull request #34: [issue-33] CPullConsumer cannot pull message because of pullResult without nextBeginOffset
URL: https://github.com/apache/rocketmq-client-cpp/pull/34#discussion_r243863355
 
 

 ##########
 File path: src/extern/CPullConsumer.cpp
 ##########
 @@ -173,12 +173,15 @@ Pull(CPullConsumer *consumer, const CMessageQueue *mq, const char *subExpression
         cppPullResult.pullStatus = BROKER_TIMEOUT;
     }
 
+    if(cppPullResult.pullStatus != BROKER_TIMEOUT){
 
 Review comment:
   why BROKER_TIMEOUT not set minOffset, maxOffset and nextBeginOffset?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services