You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/21 14:01:07 UTC

[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #3744: boards: cxd56xx: Update drivers on spresense board

jerpelea commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-nuttx/pull/3744#discussion_r636943611



##########
File path: boards/arm/cxd56xx/common/src/cxd56_altmdm.c
##########
@@ -313,6 +316,12 @@ static bool altmdm_sready(void)
 
 static void altmdm_master_request(bool request)
 {
+  /* If the GPIO falls within 300us after raising
+   * (or GPIO raises within 300us after falling), the modem may miss the GPIO
+   * interrupt. So delay by 300us before changing the GPIO.
+   */
+
+  up_udelay(WAIT_READY_TO_GPIO_INTERRUPT);

Review comment:
       fine by me 
   @davids5 what do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org