You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jmeter.apache.org by Felix Schumacher <fe...@internetallee.de> on 2015/01/04 13:07:43 UTC

BackendListenderClient docs

Hi all,

the javadoc for BackendListenerClient#handleSampleResults look 
completely wrong. I suppose they should be used for 
BackendListenerClient#createSampleResult.

But still I wonder what the returned SampleResult is used for.

Regards
  Felix

Re: BackendListenderClient docs

Posted by Felix Schumacher <fe...@internetallee.de>.

Am 06.01.2015 um 13:26 schrieb Philippe Mouawad:
> Hi Felix,
> I fixed it, could you review to tell me if it's OK for you ?
> Thanks
Patch looks good. It introduced one error, which I corrected.

Now I think the bug 57193 can be closed. I will not correct the classes 
in the reports package.

Thanks
  Felix
>
> On Tue, Jan 6, 2015 at 12:22 PM, Felix Schumacher <
> felix.schumacher@internetallee.de> wrote:
>
>> Am 04.01.2015 um 13:07 schrieb Felix Schumacher:
>>
>>> Hi all,
>>>
>>> the javadoc for BackendListenerClient#handleSampleResults look
>>> completely wrong. I suppose they should be used for BackendListenerClient#
>>> createSampleResult.
>>>
>>> But still I wonder what the returned SampleResult is used for.
>>>
>> The javadoc warnings for BackendListenerClient are the last four for the
>> whole jmeter source code (if I neglect the warnings in the reports package).
>>
>> To close Bug 57193 those javadoc comments should really be corrected.
>>
>> Regards
>>   Felix
>>
>>> Regards
>>>   Felix
>>>
>>
>

Re: BackendListenderClient docs

Posted by Philippe Mouawad <ph...@gmail.com>.

Hi Felix,
I fixed it, could you review to tell me if it's OK for you ?
Thanks

On Tue, Jan 6, 2015 at 12:22 PM, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

> Am 04.01.2015 um 13:07 schrieb Felix Schumacher:
>
>> Hi all,
>>
>> the javadoc for BackendListenerClient#handleSampleResults look
>> completely wrong. I suppose they should be used for BackendListenerClient#
>> createSampleResult.
>>
>> But still I wonder what the returned SampleResult is used for.
>>
> The javadoc warnings for BackendListenerClient are the last four for the
> whole jmeter source code (if I neglect the warnings in the reports package).
>
> To close Bug 57193 those javadoc comments should really be corrected.
>
> Regards
>  Felix
>
>>
>> Regards
>>  Felix
>>
>
>


-- 
Cordialement.
Philippe Mouawad.

Re: BackendListenderClient docs

Posted by Felix Schumacher <fe...@internetallee.de>.

Am 04.01.2015 um 13:07 schrieb Felix Schumacher:
> Hi all,
>
> the javadoc for BackendListenerClient#handleSampleResults look 
> completely wrong. I suppose they should be used for 
> BackendListenerClient#createSampleResult.
>
> But still I wonder what the returned SampleResult is used for.
The javadoc warnings for BackendListenerClient are the last four for the 
whole jmeter source code (if I neglect the warnings in the reports package).

To close Bug 57193 those javadoc comments should really be corrected.

Regards
  Felix
>
> Regards
>  Felix