[jira] [Commented] (THRIFT-2882) Lua Generator: using string.len funtion to get struct(map,list,set) size

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830597#comment-15830597 ] 

ASF GitHub Bot commented on THRIFT-2882:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/311
  
    @jfarrell this pull request can be closed - I verified the code was merged into master.


> Lua Generator: using string.len funtion to get struct(map,list,set) size
> ------------------------------------------------------------------------
>
>                 Key: THRIFT-2882
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2882
>             Project: Thrift
>          Issue Type: Bug
>          Components: Lua - Compiler
>            Reporter: winsweet
>            Assignee: Roger Meier
>             Fix For: 0.9.3
>
>
> #t_lua_generator::generate_serialize_container
> string.len can't get struct's size.
> Tables are the only "container" type in Lua.
> We can get the "length" of an array using the # operator.
> But the # operator doesn't count all the items in the table.
> So when ttype equals to list, # should be OK.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)