[jira] [Commented] (SOLR-10463) setRetryExpiryTime should be deprecated in favor of SolrClientBuilder methods

["Jason Gerlowski (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654061#comment-17654061 ] 

Jason Gerlowski commented on SOLR-10463:
----------------------------------------

bq. I flagged in the PR, there is a chance this property is not actually used???

Closing the loop here based on discussion in the PR - the property is used in some CloudSolrClient internals.

> setRetryExpiryTime should be deprecated in favor of SolrClientBuilder methods
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-10463
>                 URL: https://issues.apache.org/jira/browse/SOLR-10463
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrJ
>            Reporter: Jason Gerlowski
>            Assignee: Eric Pugh
>            Priority: Minor
>             Fix For: 7.0, 9.2
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Now that builders are in place for {{SolrClients}}, the setters used in each {{SolrClient}} can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak {{SolrClient}}s available in a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are mutable. Using some {{SolrClient}} setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the {{setRetryExpiryTime}} setter on all {{SolrClient}} implementations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org