You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/18 07:38:39 UTC
[GitHub] [dolphinscheduler-website] zhongjiajie opened a new pull request #742: Change structure of the dev directory
zhongjiajie opened a new pull request #742:
URL: https://github.com/apache/dolphinscheduler-website/pull/742
Change structure of the dev directory and make it
like version 2.0.x structure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie merged pull request #742: Change structure of the dev directory
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged pull request #742:
URL: https://github.com/apache/dolphinscheduler-website/pull/742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #742: Change structure of the dev directory
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #742:
URL: https://github.com/apache/dolphinscheduler-website/pull/742#discussion_r829883424
##########
File path: docs/en-us/dev/user_doc/architecture/design.md
##########
@@ -2,39 +2,6 @@
Before explain the architecture of the scheduling system, let's first get to know the terms commonly used in scheduling system.
Review comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] Tianqi-Dotes commented on a change in pull request #742: Change structure of the dev directory
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on a change in pull request #742:
URL: https://github.com/apache/dolphinscheduler-website/pull/742#discussion_r829875303
##########
File path: docs/en-us/dev/user_doc/architecture/design.md
##########
@@ -2,39 +2,6 @@
Before explain the architecture of the scheduling system, let's first get to know the terms commonly used in scheduling system.
Review comment:
may need to delete this sentence if remove the Glossary section or make a update.
##########
File path: docs/zh-cn/dev/user_doc/architecture/design.md
##########
@@ -1,38 +1,6 @@
## 系统架构设计
在对调度系统架构说明之前，我们先来认识一下调度系统常用的名词
Review comment:
same as EN version
##########
File path: site_config/docsdev.js
##########
@@ -569,6 +590,15 @@ export default {
},
],
},
+ {
+ title: '可观测性',
Review comment:
maybe '链路追踪' or 'Application performance monitor', I think it's not a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] Tianqi-Dotes commented on pull request #742: Change structure of the dev directory
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on pull request #742:
URL: https://github.com/apache/dolphinscheduler-website/pull/742#issuecomment-1072300683
NICE work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #742: Change structure of the dev directory
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #742:
URL: https://github.com/apache/dolphinscheduler-website/pull/742#discussion_r829883424
##########
File path: docs/en-us/dev/user_doc/architecture/design.md
##########
@@ -2,39 +2,6 @@
Before explain the architecture of the scheduling system, let's first get to know the terms commonly used in scheduling system.
Review comment:
Good catch!
##########
File path: site_config/docsdev.js
##########
@@ -569,6 +590,15 @@ export default {
},
],
},
+ {
+ title: '可观测性',
Review comment:
Hi, we should still keep `Observability` here, because it not only APM, and it will including `metrics` about meteics exprot by DolphinScheduler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #742: Change structure of the dev directory
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #742:
URL: https://github.com/apache/dolphinscheduler-website/pull/742#issuecomment-1072179718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #742: Change structure of the dev directory
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #742:
URL: https://github.com/apache/dolphinscheduler-website/pull/742#issuecomment-1072179718
@Tianqi-Dotes PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] Tianqi-Dotes commented on pull request #742: Change structure of the dev directory
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on pull request #742:
URL: https://github.com/apache/dolphinscheduler-website/pull/742#issuecomment-1072300683
NICE work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #742: Change structure of the dev directory
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #742:
URL: https://github.com/apache/dolphinscheduler-website/pull/742#discussion_r829888181
##########
File path: site_config/docsdev.js
##########
@@ -569,6 +590,15 @@ export default {
},
],
},
+ {
+ title: '可观测性',
Review comment:
Hi, we should still keep `Observability` here, because it not only APM, and it will including `metrics` about meteics exprot by DolphinScheduler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #742: Change structure of the dev directory
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #742:
URL: https://github.com/apache/dolphinscheduler-website/pull/742#issuecomment-1072294663
@Tianqi-Dotes Hi, I improved the doc base on your suggestion 👍 , but I still keep the title as `Observability ` cause we only have APM but also will have metrics for this section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie merged pull request #742: Change structure of the dev directory
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged pull request #742:
URL: https://github.com/apache/dolphinscheduler-website/pull/742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] Tianqi-Dotes commented on a change in pull request #742: Change structure of the dev directory
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on a change in pull request #742:
URL: https://github.com/apache/dolphinscheduler-website/pull/742#discussion_r829875303
##########
File path: docs/en-us/dev/user_doc/architecture/design.md
##########
@@ -2,39 +2,6 @@
Before explain the architecture of the scheduling system, let's first get to know the terms commonly used in scheduling system.
Review comment:
may need to delete this sentence if remove the Glossary section or make a update.
##########
File path: docs/zh-cn/dev/user_doc/architecture/design.md
##########
@@ -1,38 +1,6 @@
## 系统架构设计
在对调度系统架构说明之前，我们先来认识一下调度系统常用的名词
Review comment:
same as EN version
##########
File path: site_config/docsdev.js
##########
@@ -569,6 +590,15 @@ export default {
},
],
},
+ {
+ title: '可观测性',
Review comment:
maybe '链路追踪' or 'Application performance monitor', I think it's not a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org