You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2018/05/10 17:07:03 UTC
Review Request 67061: ATLAS-2670: Check validity of entity guid when
dissociating term
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67061/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-2670
https://issues.apache.org/jira/browse/ATLAS-2670
Repository: atlas
Description
-------
See JIRA
Diffs
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5e3d81846
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 5400b77c3
Diff: https://reviews.apache.org/r/67061/diff/1/
Testing
-------
PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/377/
Thanks,
Apoorv Naik
Re: Review Request 67061: ATLAS-2670: Check validity of entity guid
when dissociating term
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67061/#review203036
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 103 (patched)
<https://reviews.apache.org/r/67061/#comment285095>
In a recent change to DeleteHandler code, any internal type deletion is a hard delete. So if the term association is removed or entity is deleted the relationship is removed from the Graph.
- Apoorv Naik
On May 10, 2018, 5:07 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67061/
> -----------------------------------------------------------
>
> (Updated May 10, 2018, 5:07 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2670
> https://issues.apache.org/jira/browse/ATLAS-2670
>
>
> Repository: atlas
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5e3d81846
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 5400b77c3
>
>
> Diff: https://reviews.apache.org/r/67061/diff/1/
>
>
> Testing
> -------
>
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/377/
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 67061: ATLAS-2670: Check validity of entity guid
when dissociating term
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67061/#review202853
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On May 10, 2018, 5:07 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67061/
> -----------------------------------------------------------
>
> (Updated May 10, 2018, 5:07 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2670
> https://issues.apache.org/jira/browse/ATLAS-2670
>
>
> Repository: atlas
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5e3d81846
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 5400b77c3
>
>
> Diff: https://reviews.apache.org/r/67061/diff/1/
>
>
> Testing
> -------
>
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/377/
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 67061: ATLAS-2670: Check validity of entity guid
when dissociating term
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67061/#review202918
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 103 (patched)
<https://reviews.apache.org/r/67061/#comment284974>
should we check that the associated entity and relationship are not deleted?
- David Radley
On May 10, 2018, 5:07 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67061/
> -----------------------------------------------------------
>
> (Updated May 10, 2018, 5:07 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2670
> https://issues.apache.org/jira/browse/ATLAS-2670
>
>
> Repository: atlas
>
>
> Description
> -------
>
> See JIRA
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5e3d81846
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 5400b77c3
>
>
> Diff: https://reviews.apache.org/r/67061/diff/1/
>
>
> Testing
> -------
>
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/377/
>
>
> Thanks,
>
> Apoorv Naik
>
>