You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2021/10/03 22:01:52 UTC
svn commit: r1893862 -
/poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hwpf/model/SubdocumentType.java
Author: fanningpj
Date: Sun Oct 3 22:01:52 2021
New Revision: 1893862
URL: http://svn.apache.org/viewvc?rev=1893862&view=rev
Log:
make array into immutable collection (spotbugs issue)
Modified:
poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hwpf/model/SubdocumentType.java
Modified: poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hwpf/model/SubdocumentType.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hwpf/model/SubdocumentType.java?rev=1893862&r1=1893861&r2=1893862&view=diff
==============================================================================
--- poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hwpf/model/SubdocumentType.java (original)
+++ poi/trunk/poi-scratchpad/src/main/java/org/apache/poi/hwpf/model/SubdocumentType.java Sun Oct 3 22:01:52 2021
@@ -18,6 +18,10 @@ package org.apache.poi.hwpf.model;
import org.apache.poi.util.Internal;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+
/**
* Document text parts that can have text pieces (CPs)
*/
@@ -41,15 +45,12 @@ public enum SubdocumentType {
HEADER_TEXTBOX();
/**
- * Array of {@link SubdocumentType}s ordered by document position and FIB
+ * List of {@link SubdocumentType}s ordered by document position and FIB
* field order
*/
- public static final SubdocumentType[] ORDERED = new SubdocumentType[] {
- MAIN, FOOTNOTE, HEADER, MACRO, ANNOTATION, ENDNOTE, TEXTBOX,
- HEADER_TEXTBOX };
-
- private SubdocumentType()
- {
- }
-
+ public static final List<SubdocumentType> ORDERED = Collections.unmodifiableList(
+ Arrays.asList(
+ MAIN, FOOTNOTE, HEADER, MACRO, ANNOTATION, ENDNOTE, TEXTBOX, HEADER_TEXTBOX
+ )
+ );
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org