You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@airavata.apache.org by GitBox <gi...@apache.org> on 2020/05/03 21:28:00 UTC

[GitHub] [airavata-mft] aniruddhavpatil commented on a change in pull request #13: Feature/ftp transport - FTP Transport protocol PR

aniruddhavpatil commented on a change in pull request #13:
URL: https://github.com/apache/airavata-mft/pull/13#discussion_r419161778



##########
File path: services/secret-service/server/src/main/java/org/apache/airavata/mft/secret/server/backend/SecretBackend.java
##########
@@ -55,4 +55,9 @@
     public DropboxSecret createDropboxSecret(DropboxSecretCreateRequest request) throws Exception;
     public boolean updateDropboxSecret(DropboxSecretUpdateRequest request) throws Exception;
     public boolean deleteDropboxSecret(DropboxSecretDeleteRequest request) throws Exception;
+
+    Optional<FTPSecret> getFTPSecret(FTPSecretGetRequest request) throws Exception;

Review comment:
       @gkiran292 @DImuthuUpe 
   For keeping it uniform, I guess adding a public modifier to each of these declarations would be better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org