[GitHub] [beam] mosche commented on a diff in pull request #22093: Deprecate AWS IOs (Java) using AWS SDK v1 in favor of IOs in amazon-web-services2

[GitBox <gi...@apache.org>]

mosche commented on code in PR #22093:
URL: https://github.com/apache/beam/pull/22093#discussion_r909368789


##########
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/s3/S3FileSystem.java:
##########
@@ -120,6 +124,10 @@ class S3FileSystem extends FileSystem<S3ResourceId> {
         MoreExecutors.listeningDecorator(
             Executors.newFixedThreadPool(
                 config.getS3ThreadPoolSize(), new ThreadFactoryBuilder().setDaemon(true).build()));
+
+    LOG.warn(

Review Comment:
   The reason I added it here is that filesystems are loaded automatically... for all other IOs users should see a warning in their IDE / when compiling right? That feels a lot more noticeable than the log messages.
   
   BTW, here's the reason the logs for S3FileSystem will be extremely verbose :/
   Looks like there's a severe problem regarding initialisation of file systems with respect to `SerializablePipelineOptions`, though didn't get any feedback 
   https://lists.apache.org/thread/sp9g643lfyj6fzg9m2pym23kjv6zkbmq



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org