You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/11/04 06:03:04 UTC

[GitHub] [accumulo] ctubbsii opened a new pull request #1768: Implement IteratorEnvironment.getPluginEnv()

ctubbsii opened a new pull request #1768:
URL: https://github.com/apache/accumulo/pull/1768


   * This fixes #1766
   * Return an actual implementation for
     `IteratorEnvironment.getPluginEnv()`
   * Clean up `IteratorEnvIT.testEnv()` method to:
     * Verify implementation of `getPluginEnv()` (same object as
       `getServiceEnv()`, but with the newer API that doesn't leak internal
       types
     * Remove duplicate check of the same table configuration via
       `getServiceEnv()` and `getPluginEnv()`
     * Remove duplicate (identical) check from the deprecated `getConfig()`
       method to get the table's configuration as `AccumuloConfiguration`
     * Ensure system configuration is covered in the test via
       `getPluginEnv().getConfiguration()`
     * Ensure getting the property by the full property name via `get()`
       works as well as by the `getTableCustom()` convenience method


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii commented on pull request #1768: Implement IteratorEnvironment.getPluginEnv()

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1768:
URL: https://github.com/apache/accumulo/pull/1768#issuecomment-721858439


   > This is a solid fix for now but I am curious what we will do in the next version when we continue to clean up IteratorEnvironment, which is now part of the public API.
   
   Well, eventually, we'll drop the deprecated APIs, and move any implementation into the ones we're keeping. When that happens, the ServiceEnvironment will be redundant with the PluginEnvironment, and we can drop that interface too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii merged pull request #1768: Implement IteratorEnvironment.getPluginEnv()

Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1768:
URL: https://github.com/apache/accumulo/pull/1768


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii commented on pull request #1768: Implement IteratorEnvironment.getPluginEnv()

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1768:
URL: https://github.com/apache/accumulo/pull/1768#issuecomment-721647325


   All ITs passed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] milleruntime commented on a change in pull request #1768: Implement IteratorEnvironment.getPluginEnv()

Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #1768:
URL: https://github.com/apache/accumulo/pull/1768#discussion_r517382346



##########
File path: core/src/main/java/org/apache/accumulo/core/iterators/IteratorEnvironment.java
##########
@@ -177,7 +177,7 @@ default ServiceEnvironment getServiceEnv() {
    * @since 2.1.0
    */
   default PluginEnvironment getPluginEnv() {
-    throw new UnsupportedOperationException();
+    return getServiceEnv();

Review comment:
       This fix is very elegant, I like it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org