[GitHub] trafodion pull request #1545: Inaccurate conditions of judgment cause low ef...

[Weixin-Xu <gi...@git.apache.org>]

GitHub user Weixin-Xu opened a pull request:

    https://github.com/apache/trafodion/pull/1545

    Inaccurate conditions of judgment cause low efficiency

    In ctosqlconv.cpp, the code below :
    
    if( !(((SQLDataType == SQLTYPECODE_NUMERIC) && (targetPrecision > 18)) || 
    ((SQLDataType == SQLTYPECODE_NUMERIC_UNSIGNED) && (targetPrecision > 9))))
    
    Only when the column is NUMERIC(19+,n), the code will skip.
    It is only used for numeirc but now the other data type such as char will do the same process.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Weixin-Xu/incubator-trafodion 3049

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafodion/pull/1545.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1545
    
----
commit 6396326abe3f4a1756bc1239476b5d17b3b269e7
Author: Weixin-Xu <xw...@...>
Date:   2018-04-28T07:43:28Z

    Inaccurate conditions of judgment cause low efficiency

----


---

[GitHub] trafodion pull request #1545: [TRAFODION-3049] Inaccurate conditions of judg...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/trafodion/pull/1545


---