You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/12/18 08:02:23 UTC
[GitHub] [dubbo-go] codecov-io commented on issue #286: change the
position of the lock
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/286?src=pr&el=h1) Report
> Merging [#286](https://codecov.io/gh/apache/dubbo-go/pull/286?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d65659ff25b4c4af5dc137ba8a924a9c93a7af8a?src=pr&el=desc) will **increase** coverage by `0.74%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/286?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #286 +/- ##
===========================================
+ Coverage 65.52% 66.27% +0.74%
===========================================
Files 111 111
Lines 7063 7065 +2
===========================================
+ Hits 4628 4682 +54
+ Misses 1978 1924 -54
- Partials 457 459 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/286?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/286/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `73.36% <66.66%> (+15.49%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/286/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (-1.04%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/286/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.87% <0%> (-0.58%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/286/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0%> (+2.15%)` | :arrow_up: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/286/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `70.37% <0%> (+2.46%)` | :arrow_up: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/286/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `87.01% <0%> (+2.59%)` | :arrow_up: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/286/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `82.35% <0%> (+5.88%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/286/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `61.9% <0%> (+10.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/286?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/286?src=pr&el=footer). Last update [d65659f...d1da7ba](https://codecov.io/gh/apache/dubbo-go/pull/286?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/286 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org