[GitHub] [iceberg] pvary commented on a change in pull request #2248: Spark: Fix vectorization flags

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2248:
URL: https://github.com/apache/iceberg/pull/2248#discussion_r585586223



##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -84,6 +84,9 @@ private TableProperties() {
   public static final String PARQUET_BATCH_SIZE = "read.parquet.vectorization.batch-size";
   public static final int PARQUET_BATCH_SIZE_DEFAULT = 5000;
 
+  public static final String ORC_VECTORIZATION_ENABLED = "read.orc.vectorization.enabled";

Review comment:
       There is no vectorization yet for Hive queries, so we definitely do not use it 😈
   Why would this be a table property? In Hive world the engine decides if it reads the table in vectorized or in non-vectorized mode.
   
   Thanks,
   Peter




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org