You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2011/03/19 21:35:29 UTC

[jira] Created: (HBASE-3676) Update region server load for AssignmentManager through regionServerReport()

Update region server load for AssignmentManager through regionServerReport()
----------------------------------------------------------------------------

                 Key: HBASE-3676
                 URL: https://issues.apache.org/jira/browse/HBASE-3676
             Project: HBase
          Issue Type: Improvement
            Reporter: Ted Yu
            Assignee: Ted Yu


Currently the following method only calls serverManager.regionServerReport():
  public HMsg [] regionServerReport(HServerInfo serverInfo, HMsg msgs[],
    HRegionInfo[] mostLoadedRegions)
This means AssignmentManager doesn't have valid server load information.

The following method would be added to AssignmentManager:
public void regionServerReport(HServerInfo serverInfo, HRegionInfo[] mostLoadedRegions)

For HBASE-1502, we would figure out how to store load information through zk.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HBASE-3676) Update region server load for AssignmentManager through regionServerReport()

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008875#comment-13008875 ] 

Ted Yu commented on HBASE-3676:
-------------------------------

TestMultiParallel, TestRegionRebalancing, TestLoadBalancer, TestMasterObserver all passed.

> Update region server load for AssignmentManager through regionServerReport()
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-3676
>                 URL: https://issues.apache.org/jira/browse/HBASE-3676
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.92.0
>
>         Attachments: hbase-3676.txt
>
>
> Currently the following method only calls serverManager.regionServerReport():
>   public HMsg [] regionServerReport(HServerInfo serverInfo, HMsg msgs[],
>     HRegionInfo[] mostLoadedRegions)
> This means AssignmentManager doesn't have valid server load information.
> The following method would be added to AssignmentManager:
> public void regionServerReport(HServerInfo serverInfo, HRegionInfo[] mostLoadedRegions)
> For HBASE-1502, we would figure out how to store load information through zk.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3676) Update region server load for AssignmentManager through regionServerReport()

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009961#comment-13009961 ] 

Hudson commented on HBASE-3676:
-------------------------------

Integrated in HBase-TRUNK #1803 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1803/])
    

> Update region server load for AssignmentManager through regionServerReport()
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-3676
>                 URL: https://issues.apache.org/jira/browse/HBASE-3676
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.92.0
>
>         Attachments: hbase-3676-server-mgr.txt, hbase-3676.txt
>
>
> Currently the following method only calls serverManager.regionServerReport():
>   public HMsg [] regionServerReport(HServerInfo serverInfo, HMsg msgs[],
>     HRegionInfo[] mostLoadedRegions)
> This means AssignmentManager doesn't have valid server load information.
> The following method would be added to AssignmentManager:
> public void regionServerReport(HServerInfo serverInfo, HRegionInfo[] mostLoadedRegions)
> For HBASE-1502, we would figure out how to store load information through zk.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HBASE-3676) Update region server load for AssignmentManager through regionServerReport()

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-3676:
-------------------------

    Fix Version/s: 0.92.0

Bringing into 0.92 but going to wait on commit...

> Update region server load for AssignmentManager through regionServerReport()
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-3676
>                 URL: https://issues.apache.org/jira/browse/HBASE-3676
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.92.0
>
>         Attachments: hbase-3676.txt
>
>
> Currently the following method only calls serverManager.regionServerReport():
>   public HMsg [] regionServerReport(HServerInfo serverInfo, HMsg msgs[],
>     HRegionInfo[] mostLoadedRegions)
> This means AssignmentManager doesn't have valid server load information.
> The following method would be added to AssignmentManager:
> public void regionServerReport(HServerInfo serverInfo, HRegionInfo[] mostLoadedRegions)
> For HBASE-1502, we would figure out how to store load information through zk.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (HBASE-3676) Update region server load for AssignmentManager through regionServerReport()

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-3676:
--------------------------

    Attachment: hbase-3676.txt

Also includes change of regionLoad to TreeMap in HServerLoad.java
This would facilitate making better load balancing decision in the future.

> Update region server load for AssignmentManager through regionServerReport()
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-3676
>                 URL: https://issues.apache.org/jira/browse/HBASE-3676
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: hbase-3676.txt
>
>
> Currently the following method only calls serverManager.regionServerReport():
>   public HMsg [] regionServerReport(HServerInfo serverInfo, HMsg msgs[],
>     HRegionInfo[] mostLoadedRegions)
> This means AssignmentManager doesn't have valid server load information.
> The following method would be added to AssignmentManager:
> public void regionServerReport(HServerInfo serverInfo, HRegionInfo[] mostLoadedRegions)
> For HBASE-1502, we would figure out how to store load information through zk.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HBASE-3676) Update region server load for AssignmentManager through regionServerReport()

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-3676.
--------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]

Applied to TRUNK. Thanks for the patch Ted Yu (FYI, 80 chars per line and no tabs in future).

> Update region server load for AssignmentManager through regionServerReport()
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-3676
>                 URL: https://issues.apache.org/jira/browse/HBASE-3676
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.92.0
>
>         Attachments: hbase-3676-server-mgr.txt, hbase-3676.txt
>
>
> Currently the following method only calls serverManager.regionServerReport():
>   public HMsg [] regionServerReport(HServerInfo serverInfo, HMsg msgs[],
>     HRegionInfo[] mostLoadedRegions)
> This means AssignmentManager doesn't have valid server load information.
> The following method would be added to AssignmentManager:
> public void regionServerReport(HServerInfo serverInfo, HRegionInfo[] mostLoadedRegions)
> For HBASE-1502, we would figure out how to store load information through zk.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3676) Update region server load for AssignmentManager through regionServerReport()

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009387#comment-13009387 ] 

Ted Yu commented on HBASE-3676:
-------------------------------

The following tests pass for the latest patch: TestMasterObserver, TestRegionRebalancing, TestMultiParallel, TestLoadBalancer

> Update region server load for AssignmentManager through regionServerReport()
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-3676
>                 URL: https://issues.apache.org/jira/browse/HBASE-3676
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.92.0
>
>         Attachments: hbase-3676-server-mgr.txt, hbase-3676.txt
>
>
> Currently the following method only calls serverManager.regionServerReport():
>   public HMsg [] regionServerReport(HServerInfo serverInfo, HMsg msgs[],
>     HRegionInfo[] mostLoadedRegions)
> This means AssignmentManager doesn't have valid server load information.
> The following method would be added to AssignmentManager:
> public void regionServerReport(HServerInfo serverInfo, HRegionInfo[] mostLoadedRegions)
> For HBASE-1502, we would figure out how to store load information through zk.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-3676) Update region server load for AssignmentManager through regionServerReport()

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-3676:
--------------------------

    Attachment: hbase-3676-server-mgr.txt

It turns out that ServerManager.processRegionServerAllsWell() is doing server info refresh.
This patch removes the new method in AssignmentManager and adds the following method to ServerManager:
{code}
  HServerLoad getLoad(String serverName) {
{code}
so that server load is accessible to AssignmentManager

> Update region server load for AssignmentManager through regionServerReport()
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-3676
>                 URL: https://issues.apache.org/jira/browse/HBASE-3676
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.92.0
>
>         Attachments: hbase-3676-server-mgr.txt, hbase-3676.txt
>
>
> Currently the following method only calls serverManager.regionServerReport():
>   public HMsg [] regionServerReport(HServerInfo serverInfo, HMsg msgs[],
>     HRegionInfo[] mostLoadedRegions)
> This means AssignmentManager doesn't have valid server load information.
> The following method would be added to AssignmentManager:
> public void regionServerReport(HServerInfo serverInfo, HRegionInfo[] mostLoadedRegions)
> For HBASE-1502, we would figure out how to store load information through zk.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Work started: (HBASE-3676) Update region server load for AssignmentManager through regionServerReport()

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on HBASE-3676 started by Ted Yu.

> Update region server load for AssignmentManager through regionServerReport()
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-3676
>                 URL: https://issues.apache.org/jira/browse/HBASE-3676
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>
> Currently the following method only calls serverManager.regionServerReport():
>   public HMsg [] regionServerReport(HServerInfo serverInfo, HMsg msgs[],
>     HRegionInfo[] mostLoadedRegions)
> This means AssignmentManager doesn't have valid server load information.
> The following method would be added to AssignmentManager:
> public void regionServerReport(HServerInfo serverInfo, HRegionInfo[] mostLoadedRegions)
> For HBASE-1502, we would figure out how to store load information through zk.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira