You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/05/08 01:47:47 UTC

[GitHub] [arrow] wgtmac commented on a diff in pull request #35462: GH-35461: [C++] Add function Seek to BufferOutputStream

wgtmac commented on code in PR #35462:
URL: https://github.com/apache/arrow/pull/35462#discussion_r1186959238


##########
cpp/src/arrow/io/memory.cc:
##########
@@ -110,6 +110,21 @@ Status BufferOutputStream::Write(const void* data, int64_t nbytes) {
   return Status::OK();
 }
 
+Status BufferOutputStream::Seek(int64_t position) {

Review Comment:
   I'd prefer creating a separate class for the seekable output stream as its semantics is append-only and downstream applications are using it with that assumption.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org