You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2017/04/25 23:19:02 UTC

[GitHub] kafka pull request #2915: KAFKA-5119: Improve information in assert failure ...

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/2915

    KAFKA-5119: Improve information in assert failure for testMetricCollectionAfterShutdown

    This test is failing consistently in https://jenkins.confluent.io/job/kafka-trunk/,
    but nowhere else. I ran this branch in a clone of that job several times and this
    test didn't fail. I suggest we merge this PR, which improves the test, to help us
    gather more information about the test failure.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka socket-server-test-metric-collection-after-shutdown

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2915.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2915
    
----
commit aba3ed482e41db011974a44de72e57bc2e3b1a7d
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-04-24T22:12:18Z

    MINOR: Improve information in assert failure for testMetricCollectionAfterShutdown

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #2915: KAFKA-5119: Ensure global metrics are empty before...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/2915


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---