You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "felixwluo (via GitHub)" <gi...@apache.org> on 2024/10/30 13:52:34 UTC
[PR] [feat](nereids) support drop database in nereids [doris]
felixwluo opened a new pull request, #42935:
URL: https://github.com/apache/doris/pull/42935
## Proposed changes
Issue Number: close #42612
This pr supports drop database stmt in nereids planner
`drop database test force`
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2586560395
<details>
<summary>TPC-H: <b>Total hot run time: 32491 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2e70d26dd5139ff9f156e837d8b9eb58fc576850, data reload: false
------ Round 1 ----------------------------------
q1 17579 6157 6050 6050
q2 2047 299 178 178
q3 10408 1252 699 699
q4 10219 853 438 438
q5 7509 2113 1965 1965
q6 210 180 149 149
q7 888 752 611 611
q8 9231 1338 1123 1123
q9 5147 4867 4881 4867
q10 6734 2309 1863 1863
q11 488 278 260 260
q12 355 351 217 217
q13 17749 3665 3048 3048
q14 239 228 214 214
q15 555 505 504 504
q16 627 617 588 588
q17 555 846 324 324
q18 6934 6452 6437 6437
q19 1211 968 527 527
q20 307 328 199 199
q21 2812 2136 1913 1913
q22 363 329 317 317
Total cold run time: 102167 ms
Total hot run time: 32491 ms
----- Round 2, with runtime_filter_mode=off -----
q1 6218 6412 6212 6212
q2 252 330 247 247
q3 2255 2686 2269 2269
q4 1437 1761 1360 1360
q5 4298 4739 4635 4635
q6 198 178 145 145
q7 2078 2011 1816 1816
q8 2613 2758 2674 2674
q9 7268 7209 7158 7158
q10 3014 3300 2801 2801
q11 574 518 492 492
q12 708 755 644 644
q13 3468 3853 3237 3237
q14 281 296 272 272
q15 570 515 506 506
q16 652 664 633 633
q17 1242 1708 1238 1238
q18 7714 7466 7083 7083
q19 724 993 1053 993
q20 1920 1951 1788 1788
q21 5445 5116 4764 4764
q22 627 608 554 554
Total cold run time: 53556 ms
Total hot run time: 51521 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2574721678
<details>
<summary>TPC-H: <b>Total hot run time: 32950 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a97f35931c6d7ac22dea10d932abbb1e52fb78da, data reload: false
------ Round 1 ----------------------------------
q1 17873 6228 6138 6138
q2 2051 296 176 176
q3 10546 1238 772 772
q4 10205 878 440 440
q5 7663 2220 2037 2037
q6 214 186 150 150
q7 928 766 601 601
q8 9235 1417 1237 1237
q9 5367 4965 4909 4909
q10 6796 2295 1862 1862
q11 476 283 275 275
q12 343 360 217 217
q13 17787 3712 3007 3007
q14 234 230 221 221
q15 554 512 484 484
q16 651 607 595 595
q17 587 870 352 352
q18 7059 6388 6413 6388
q19 2113 959 588 588
q20 312 323 195 195
q21 2917 2261 2006 2006
q22 354 327 300 300
Total cold run time: 104265 ms
Total hot run time: 32950 ms
----- Round 2, with runtime_filter_mode=off -----
q1 6358 6303 6259 6259
q2 242 319 232 232
q3 2259 2664 2304 2304
q4 1464 1916 1369 1369
q5 4388 4786 4916 4786
q6 195 173 138 138
q7 2070 1931 1810 1810
q8 2665 2837 2702 2702
q9 7277 7248 7310 7248
q10 3106 3355 2870 2870
q11 603 511 495 495
q12 651 705 599 599
q13 3546 3891 3281 3281
q14 305 331 277 277
q15 568 521 528 521
q16 695 716 637 637
q17 1244 1746 1264 1264
q18 7626 7431 7426 7426
q19 894 1210 1078 1078
q20 2025 2013 1959 1959
q21 5688 5327 4959 4959
q22 653 614 610 610
Total cold run time: 54522 ms
Total hot run time: 52824 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "felixwluo (via GitHub)" <gi...@apache.org>.
felixwluo commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2574569762
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2576785651
<details>
<summary>TPC-H: <b>Total hot run time: 32696 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3e82e48f49dbdf0830831d25ecce274403389ae8, data reload: false
------ Round 1 ----------------------------------
q1 17569 6276 6123 6123
q2 2045 317 169 169
q3 10522 1243 737 737
q4 10189 862 442 442
q5 7617 2190 2013 2013
q6 205 200 153 153
q7 896 750 602 602
q8 9238 1348 1227 1227
q9 5149 4814 4973 4814
q10 6744 2314 1837 1837
q11 466 288 265 265
q12 341 363 220 220
q13 17760 3676 3022 3022
q14 240 247 209 209
q15 560 502 487 487
q16 635 615 603 603
q17 565 858 328 328
q18 7079 6409 6426 6409
q19 2159 986 544 544
q20 302 315 187 187
q21 2946 2227 2004 2004
q22 374 339 301 301
Total cold run time: 103601 ms
Total hot run time: 32696 ms
----- Round 2, with runtime_filter_mode=off -----
q1 6389 6396 6316 6316
q2 237 328 234 234
q3 2227 2679 2315 2315
q4 1474 1875 1369 1369
q5 4352 4750 4875 4750
q6 197 183 152 152
q7 2056 1949 1842 1842
q8 2684 2860 2715 2715
q9 7326 7227 7232 7227
q10 3073 3367 2764 2764
q11 570 504 501 501
q12 668 815 649 649
q13 3557 3896 3185 3185
q14 278 300 277 277
q15 563 538 503 503
q16 652 706 665 665
q17 1218 1751 1250 1250
q18 7761 7468 7434 7434
q19 834 1207 1124 1124
q20 2025 2063 1954 1954
q21 5857 5260 4905 4905
q22 660 630 591 591
Total cold run time: 54658 ms
Total hot run time: 52722 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "felixwluo (via GitHub)" <gi...@apache.org>.
felixwluo commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2453807527
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2453836275
<details>
<summary>ClickBench: <b>Total hot run time: 32.19 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2888fb83af49d68fc16a4459ca65bd5a0a4f8dec, data reload: false
query1 0.03 0.03 0.03
query2 0.06 0.03 0.03
query3 0.23 0.06 0.06
query4 1.63 0.10 0.10
query5 0.40 0.40 0.40
query6 1.16 0.65 0.65
query7 0.02 0.02 0.01
query8 0.04 0.04 0.03
query9 0.57 0.50 0.49
query10 0.55 0.55 0.57
query11 0.14 0.10 0.10
query12 0.14 0.10 0.11
query13 0.60 0.60 0.58
query14 2.72 2.72 2.71
query15 0.91 0.83 0.82
query16 0.38 0.38 0.37
query17 1.06 1.07 1.06
query18 0.20 0.20 0.20
query19 1.91 1.81 1.90
query20 0.02 0.01 0.01
query21 15.35 0.60 0.57
query22 2.74 2.91 1.80
query23 16.98 1.01 0.71
query24 2.99 1.99 0.67
query25 0.27 0.17 0.22
query26 0.28 0.14 0.14
query27 0.04 0.05 0.04
query28 10.20 1.09 1.06
query29 12.51 3.22 3.23
query30 0.24 0.06 0.06
query31 2.87 0.39 0.38
query32 3.28 0.46 0.45
query33 3.01 3.02 3.04
query34 17.04 4.50 4.47
query35 4.55 4.53 4.59
query36 0.68 0.49 0.49
query37 0.09 0.06 0.06
query38 0.04 0.03 0.04
query39 0.04 0.02 0.03
query40 0.15 0.12 0.13
query41 0.08 0.03 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 106.27 s
Total hot run time: 32.19 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2586597410
<details>
<summary>ClickBench: <b>Total hot run time: 31.67 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2e70d26dd5139ff9f156e837d8b9eb58fc576850, data reload: false
query1 0.03 0.03 0.03
query2 0.07 0.03 0.04
query3 0.25 0.08 0.07
query4 1.62 0.10 0.10
query5 0.42 0.39 0.40
query6 1.16 0.65 0.64
query7 0.02 0.01 0.01
query8 0.04 0.03 0.04
query9 0.57 0.51 0.51
query10 0.56 0.57 0.55
query11 0.15 0.11 0.11
query12 0.14 0.11 0.11
query13 0.60 0.60 0.58
query14 2.72 2.74 2.78
query15 0.90 0.82 0.82
query16 0.39 0.38 0.39
query17 1.03 1.05 1.07
query18 0.24 0.21 0.21
query19 1.86 1.86 1.96
query20 0.01 0.01 0.01
query21 15.41 1.00 0.61
query22 0.75 0.80 0.79
query23 15.17 1.53 0.53
query24 3.24 1.08 1.29
query25 0.14 0.16 0.07
query26 0.30 0.14 0.13
query27 0.06 0.05 0.05
query28 14.46 1.53 1.04
query29 12.55 4.10 3.39
query30 0.24 0.08 0.06
query31 2.83 0.60 0.38
query32 3.23 0.55 0.46
query33 3.12 3.11 3.17
query34 16.90 5.17 4.47
query35 4.54 4.46 4.50
query36 0.65 0.50 0.50
query37 0.10 0.06 0.06
query38 0.05 0.04 0.04
query39 0.04 0.03 0.02
query40 0.16 0.14 0.12
query41 0.08 0.03 0.02
query42 0.04 0.02 0.03
query43 0.04 0.03 0.03
Total cold run time: 106.88 s
Total hot run time: 31.67 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2576798483
<details>
<summary>TPC-DS: <b>Total hot run time: 195402 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3e82e48f49dbdf0830831d25ecce274403389ae8, data reload: false
query1 1279 923 930 923
query2 6456 2330 2300 2300
query3 11081 4948 4870 4870
query4 32775 23600 23302 23302
query5 4227 606 445 445
query6 275 206 188 188
query7 4010 487 318 318
query8 310 259 217 217
query9 9375 2728 2723 2723
query10 462 299 237 237
query11 17728 15177 15176 15176
query12 154 104 102 102
query13 1563 524 391 391
query14 9640 6993 7100 6993
query15 258 217 185 185
query16 8070 673 473 473
query17 1497 763 568 568
query18 2171 423 314 314
query19 214 179 164 164
query20 124 116 115 115
query21 210 119 124 119
query22 4585 4679 4631 4631
query23 34232 33436 33115 33115
query24 6396 2298 2288 2288
query25 493 492 428 428
query26 883 276 157 157
query27 2057 472 346 346
query28 5588 2516 2518 2516
query29 701 551 412 412
query30 213 193 152 152
query31 907 917 811 811
query32 90 62 54 54
query33 473 355 295 295
query34 751 852 515 515
query35 856 852 750 750
query36 1022 1033 954 954
query37 115 111 81 81
query38 4152 4164 3971 3971
query39 1513 1467 1439 1439
query40 206 117 99 99
query41 46 46 47 46
query42 127 108 108 108
query43 531 551 499 499
query44 1365 841 830 830
query45 186 175 163 163
query46 858 1044 652 652
query47 1958 1900 1861 1861
query48 395 409 344 344
query49 726 476 410 410
query50 654 658 406 406
query51 7088 7071 7003 7003
query52 109 102 93 93
query53 221 247 187 187
query54 493 487 412 412
query55 84 82 80 80
query56 253 249 224 224
query57 1215 1222 1145 1145
query58 239 242 235 235
query59 3116 3325 3124 3124
query60 280 287 273 273
query61 143 129 126 126
query62 846 785 737 737
query63 242 187 196 187
query64 3825 1039 658 658
query65 3299 3248 3190 3190
query66 992 419 321 321
query67 16560 15753 15380 15380
query68 9013 694 516 516
query69 471 300 251 251
query70 1199 1073 1106 1073
query71 419 277 253 253
query72 6479 3841 3829 3829
query73 662 738 359 359
query74 9765 9226 9111 9111
query75 3958 3121 2647 2647
query76 3602 1183 769 769
query77 770 352 266 266
query78 10832 10121 9483 9483
query79 5197 775 570 570
query80 694 543 531 531
query81 470 277 226 226
query82 558 155 129 129
query83 187 157 144 144
query84 279 88 73 73
query85 790 378 309 309
query86 356 317 301 301
query87 4361 4394 4194 4194
query88 4271 2207 2171 2171
query89 416 305 292 292
query90 1979 187 186 186
query91 127 132 104 104
query92 65 55 54 54
query93 1857 725 523 523
query94 677 393 288 288
query95 341 273 257 257
query96 482 615 277 277
query97 2893 2977 2801 2801
query98 217 207 193 193
query99 1668 1464 1391 1391
Total cold run time: 298018 ms
Total hot run time: 195402 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "felixwluo (via GitHub)" <gi...@apache.org>.
felixwluo commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2575788662
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on code in PR #42935:
URL: https://github.com/apache/doris/pull/42935#discussion_r1822722842
##########
regression-test/suites/ddl_p0/test_drop_force.groovy:
##########
@@ -71,5 +71,11 @@ suite("sql_force_drop") {
sql " drop database test_force_drop_database "
sql " recover database test_force_drop_database "
sql " drop database test_force_drop_database FORCE"
+
+ sql "CREATE DATABASE IF NOT EXISTS test_drop_database_nereids"
+ sql "SET enable_nereids_planner=true"
+ sql "SET enable_fallback_to_original_planner=false"
+ sql "drop database test_drop_database_nereids FORCE"
Review Comment:
add a case: drop catalog.database?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2456423114
<details>
<summary>TPC-H: <b>Total hot run time: 41299 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 21e8208c99260b0a05bc79e698ff4dca0d5de9ce, data reload: false
------ Round 1 ----------------------------------
q1 17589 7459 7259 7259
q2 2058 165 161 161
q3 10778 1063 1165 1063
q4 10537 827 791 791
q5 7732 3146 3108 3108
q6 236 146 145 145
q7 1023 613 605 605
q8 9343 1988 2011 1988
q9 6566 6420 6523 6420
q10 7066 2420 2425 2420
q11 463 279 253 253
q12 404 215 216 215
q13 17769 3013 3017 3013
q14 232 211 208 208
q15 580 519 522 519
q16 643 578 601 578
q17 968 549 600 549
q18 7621 6765 6675 6675
q19 1348 1028 1000 1000
q20 470 184 183 183
q21 4181 3207 3169 3169
q22 1129 993 977 977
Total cold run time: 108736 ms
Total hot run time: 41299 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7273 7209 7279 7209
q2 314 222 218 218
q3 2994 3000 2958 2958
q4 2128 1870 1798 1798
q5 5771 5788 5821 5788
q6 228 144 149 144
q7 2225 1843 1805 1805
q8 3382 3523 3468 3468
q9 8914 8903 8885 8885
q10 3582 3589 3574 3574
q11 605 511 505 505
q12 815 634 607 607
q13 8635 3264 3186 3186
q14 303 276 276 276
q15 587 522 526 522
q16 679 649 641 641
q17 1838 1630 1637 1630
q18 8536 7833 7597 7597
q19 1701 1604 1596 1596
q20 2155 1837 1876 1837
q21 5667 5452 5535 5452
q22 1118 1078 1051 1051
Total cold run time: 69450 ms
Total hot run time: 60747 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "felixwluo (via GitHub)" <gi...@apache.org>.
felixwluo commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2454213988
> @felixwluo please update all old void dropDb(DropDbStmt stmt) method to call the new dropDb function you added to prevent duplicate code
Thank you, please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2574760274
<details>
<summary>ClickBench: <b>Total hot run time: 30.61 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a97f35931c6d7ac22dea10d932abbb1e52fb78da, data reload: false
query1 0.04 0.04 0.03
query2 0.07 0.04 0.04
query3 0.24 0.06 0.07
query4 1.62 0.11 0.10
query5 0.40 0.42 0.41
query6 1.14 0.65 0.65
query7 0.02 0.01 0.01
query8 0.04 0.03 0.03
query9 0.60 0.49 0.50
query10 0.56 0.56 0.56
query11 0.15 0.10 0.10
query12 0.14 0.11 0.10
query13 0.60 0.60 0.59
query14 2.73 2.74 2.76
query15 0.90 0.82 0.83
query16 0.38 0.38 0.38
query17 1.08 1.06 1.05
query18 0.23 0.22 0.21
query19 1.97 1.85 1.98
query20 0.01 0.01 0.02
query21 15.37 0.96 0.57
query22 0.75 0.66 0.64
query23 15.45 1.44 0.62
query24 2.94 0.35 1.68
query25 0.18 0.22 0.05
query26 0.30 0.16 0.14
query27 0.06 0.05 0.06
query28 13.48 1.56 1.04
query29 12.57 4.06 3.34
query30 0.25 0.08 0.06
query31 2.83 0.62 0.39
query32 3.22 0.55 0.46
query33 3.12 3.26 3.01
query34 16.56 5.07 4.46
query35 4.51 4.43 4.50
query36 0.65 0.49 0.47
query37 0.09 0.06 0.05
query38 0.05 0.03 0.03
query39 0.04 0.02 0.03
query40 0.16 0.13 0.13
query41 0.08 0.03 0.02
query42 0.04 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 105.66 s
Total hot run time: 30.61 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "felixwluo (via GitHub)" <gi...@apache.org>.
felixwluo commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2586520771
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "felixwluo (via GitHub)" <gi...@apache.org>.
felixwluo commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2586788511
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2447233462
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2456452437
<details>
<summary>ClickBench: <b>Total hot run time: 32.74 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 21e8208c99260b0a05bc79e698ff4dca0d5de9ce, data reload: false
query1 0.04 0.03 0.03
query2 0.07 0.03 0.04
query3 0.23 0.07 0.06
query4 1.63 0.10 0.11
query5 0.41 0.41 0.41
query6 1.14 0.67 0.65
query7 0.03 0.02 0.02
query8 0.03 0.03 0.02
query9 0.57 0.52 0.49
query10 0.54 0.55 0.56
query11 0.14 0.10 0.11
query12 0.14 0.11 0.10
query13 0.61 0.60 0.59
query14 2.83 2.84 2.76
query15 0.89 0.82 0.82
query16 0.39 0.38 0.37
query17 1.06 1.08 1.05
query18 0.20 0.20 0.21
query19 1.98 1.88 2.03
query20 0.01 0.01 0.01
query21 15.35 0.62 0.58
query22 2.74 2.80 1.71
query23 16.99 0.87 0.96
query24 3.09 2.03 1.28
query25 0.18 0.16 0.04
query26 0.67 0.14 0.13
query27 0.04 0.04 0.04
query28 9.57 1.11 1.07
query29 12.58 3.23 3.21
query30 0.25 0.06 0.06
query31 2.88 0.40 0.37
query32 3.26 0.46 0.46
query33 3.02 3.02 3.05
query34 17.12 4.48 4.42
query35 4.55 4.46 4.48
query36 0.67 0.50 0.48
query37 0.10 0.06 0.06
query38 0.05 0.04 0.03
query39 0.03 0.03 0.02
query40 0.14 0.12 0.12
query41 0.08 0.02 0.02
query42 0.04 0.02 0.02
query43 0.03 0.03 0.03
Total cold run time: 106.37 s
Total hot run time: 32.74 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2448868715
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2453831815
<details>
<summary>TPC-DS: <b>Total hot run time: 191336 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2888fb83af49d68fc16a4459ca65bd5a0a4f8dec, data reload: false
query1 970 364 366 364
query2 5786 2028 2005 2005
query3 6464 229 216 216
query4 33734 23585 23925 23585
query5 4051 439 430 430
query6 271 172 166 166
query7 4468 286 306 286
query8 297 227 219 219
query9 9436 2727 2728 2727
query10 460 252 266 252
query11 18379 15392 15533 15392
query12 145 104 113 104
query13 1703 430 432 430
query14 9641 6886 7372 6886
query15 273 182 179 179
query16 7290 470 451 451
query17 1566 582 555 555
query18 2064 299 295 295
query19 380 150 144 144
query20 114 111 106 106
query21 212 101 100 100
query22 4507 4274 4432 4274
query23 34953 34017 33989 33989
query24 11334 2765 2735 2735
query25 685 399 408 399
query26 1727 157 159 157
query27 2783 280 285 280
query28 7994 2497 2471 2471
query29 849 423 429 423
query30 318 155 152 152
query31 1027 813 832 813
query32 65 57 63 57
query33 752 279 277 277
query34 915 501 523 501
query35 874 751 743 743
query36 1119 942 958 942
query37 220 76 73 73
query38 4405 4239 4373 4239
query39 1484 1430 1443 1430
query40 283 101 100 100
query41 50 47 54 47
query42 107 101 96 96
query43 527 482 489 482
query44 1204 822 827 822
query45 185 167 165 165
query46 1124 693 705 693
query47 1981 1837 1868 1837
query48 421 316 321 316
query49 1180 403 409 403
query50 799 376 396 376
query51 7319 7129 7053 7053
query52 99 91 91 91
query53 253 181 178 178
query54 1258 406 408 406
query55 78 75 81 75
query56 252 237 248 237
query57 1262 1183 1171 1171
query58 227 205 200 200
query59 3114 2919 2946 2919
query60 267 250 246 246
query61 104 98 104 98
query62 867 680 686 680
query63 216 188 184 184
query64 3797 625 601 601
query65 3352 3271 3231 3231
query66 1207 300 302 300
query67 16468 15992 15634 15634
query68 4745 561 550 550
query69 416 248 249 248
query70 1182 1131 1063 1063
query71 396 253 244 244
query72 5965 3956 3988 3956
query73 772 350 368 350
query74 10320 9034 9023 9023
query75 3404 2667 2676 2667
query76 2259 983 1038 983
query77 414 265 263 263
query78 10342 9384 9400 9384
query79 1120 591 589 589
query80 761 420 415 415
query81 520 242 238 238
query82 1209 116 118 116
query83 240 139 136 136
query84 233 68 69 68
query85 1060 328 299 299
query86 319 297 304 297
query87 4815 4770 4648 4648
query88 3333 2257 2171 2171
query89 402 289 293 289
query90 2139 186 180 180
query91 134 100 103 100
query92 59 49 49 49
query93 1036 545 541 541
query94 869 290 286 286
query95 355 236 251 236
query96 623 279 282 279
query97 2899 2682 2660 2660
query98 212 198 199 198
query99 1519 1350 1322 1322
Total cold run time: 295788 ms
Total hot run time: 191336 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2456442757
<details>
<summary>TPC-DS: <b>Total hot run time: 196479 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 21e8208c99260b0a05bc79e698ff4dca0d5de9ce, data reload: false
query1 1226 924 948 924
query2 6238 2035 2015 2015
query3 10781 4056 4030 4030
query4 68064 29416 23705 23705
query5 5089 467 440 440
query6 428 178 185 178
query7 5569 301 294 294
query8 315 233 231 231
query9 8630 2666 2659 2659
query10 431 251 247 247
query11 17513 15546 15826 15546
query12 151 106 100 100
query13 1559 479 406 406
query14 9946 7825 7194 7194
query15 217 192 194 192
query16 7084 499 459 459
query17 1025 559 558 558
query18 1791 310 303 303
query19 207 153 154 153
query20 125 110 114 110
query21 200 104 99 99
query22 4422 4401 4295 4295
query23 34403 34253 34062 34062
query24 6079 2798 2785 2785
query25 525 407 406 406
query26 651 164 162 162
query27 1687 291 291 291
query28 4204 2448 2421 2421
query29 687 437 416 416
query30 236 154 153 153
query31 984 798 789 789
query32 69 58 66 58
query33 400 267 272 267
query34 927 526 542 526
query35 849 731 729 729
query36 1098 963 968 963
query37 115 77 79 77
query38 4397 4233 4258 4233
query39 1474 1468 1415 1415
query40 200 101 98 98
query41 46 46 46 46
query42 112 97 100 97
query43 522 484 491 484
query44 1207 838 837 837
query45 181 171 164 164
query46 1121 697 708 697
query47 1949 1856 1853 1853
query48 421 336 328 328
query49 739 404 391 391
query50 803 397 392 392
query51 7359 7168 7097 7097
query52 96 90 86 86
query53 251 182 181 181
query54 519 397 389 389
query55 73 75 74 74
query56 255 236 228 228
query57 1307 1186 1167 1167
query58 212 197 203 197
query59 3229 3026 2838 2838
query60 268 238 248 238
query61 103 101 109 101
query62 831 708 662 662
query63 220 187 180 180
query64 1339 669 620 620
query65 3279 3240 3216 3216
query66 712 301 294 294
query67 15969 15628 15553 15553
query68 2963 577 603 577
query69 428 251 260 251
query70 1209 1158 1155 1155
query71 358 250 264 250
query72 6197 4122 3967 3967
query73 766 362 361 361
query74 10000 9098 9063 9063
query75 3416 2663 2671 2663
query76 1732 1072 1119 1072
query77 476 289 266 266
query78 10430 9457 9372 9372
query79 1133 600 593 593
query80 848 422 436 422
query81 513 241 241 241
query82 1288 118 115 115
query83 223 134 135 134
query84 281 68 72 68
query85 891 301 298 298
query86 358 307 295 295
query87 4870 4728 4601 4601
query88 3371 2208 2160 2160
query89 415 294 287 287
query90 2035 187 190 187
query91 137 99 105 99
query92 66 46 49 46
query93 1301 551 549 549
query94 831 287 293 287
query95 346 252 247 247
query96 617 272 283 272
query97 2894 2670 2673 2670
query98 210 201 203 201
query99 1827 1314 1311 1311
Total cold run time: 315549 ms
Total hot run time: 196479 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "felixwluo (via GitHub)" <gi...@apache.org>.
felixwluo commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2456383521
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "felixwluo (via GitHub)" <gi...@apache.org>.
felixwluo commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2576698286
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "felixwluo (via GitHub)" <gi...@apache.org>.
felixwluo commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2447235951
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2448868665
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #42935:
URL: https://github.com/apache/doris/pull/42935#discussion_r1823706043
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DropDatabaseCommand.java:
##########
@@ -0,0 +1,95 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands;
+
+import org.apache.doris.analysis.StmtType;
+import org.apache.doris.catalog.DatabaseIf;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.catalog.MysqlCompatibleDatabase;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.common.UserException;
+import org.apache.doris.common.util.InternalDatabaseUtil;
+import org.apache.doris.datasource.InternalCatalog;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.commands.info.DropDatabaseInfo;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.StmtExecutor;
+
+import com.google.common.base.Strings;
+import org.apache.commons.lang3.StringUtils;
+
+/**
+ * drop database command
+ */
+public class DropDatabaseCommand extends Command implements ForwardWithSync {
+ private final DropDatabaseInfo dropDatabaseInfo;
+
+ public DropDatabaseCommand(DropDatabaseInfo dropDatabaseInfo) {
+ super(PlanType.DROP_DATABASE_COMMAND);
+ this.dropDatabaseInfo = dropDatabaseInfo;
+ }
+
+ private void analyze(ConnectContext ctx) throws UserException {
+ String databaseName = dropDatabaseInfo.getDatabaseName();
+ String catalogName = dropDatabaseInfo.getCatalogName();
+ if (Strings.isNullOrEmpty(databaseName)) {
+ ErrorReport.reportAnalysisException(ErrorCode.ERR_WRONG_DB_NAME, databaseName);
+ }
+
+ InternalDatabaseUtil.checkDatabase(databaseName, ctx);
+
+ DatabaseIf db = Env.getCurrentInternalCatalog().getDbNullable(databaseName);
+ if (db != null && db instanceof MysqlCompatibleDatabase) {
+ ErrorReport.reportAnalysisException(ErrorCode.ERR_DBACCESS_DENIED_ERROR,
+ ctx.getQualifiedUser(), databaseName);
+ }
+
+ String effectiveCatalog = StringUtils.isEmpty(catalogName)
+ ? InternalCatalog.INTERNAL_CATALOG_NAME : catalogName;
+
+ if (!Env.getCurrentEnv().getAccessManager()
+ .checkDbPriv(ctx, effectiveCatalog, databaseName, PrivPredicate.DROP)) {
+ ErrorReport.reportAnalysisException(ErrorCode.ERR_DBACCESS_DENIED_ERROR,
+ ctx.getQualifiedUser(), databaseName);
+ }
+ }
+
+ @Override
+ public void run(ConnectContext ctx, StmtExecutor executor) throws Exception {
+ try {
+ analyze(ctx);
+ Env.getCurrentEnv().dropDb(dropDatabaseInfo.toDropDbStmt());
Review Comment:
we should not reuse DropDbStmt anymore, reimplement Env#dropDb without it
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DropDatabaseCommand.java:
##########
@@ -0,0 +1,95 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands;
+
+import org.apache.doris.analysis.StmtType;
+import org.apache.doris.catalog.DatabaseIf;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.catalog.MysqlCompatibleDatabase;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.common.UserException;
+import org.apache.doris.common.util.InternalDatabaseUtil;
+import org.apache.doris.datasource.InternalCatalog;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.commands.info.DropDatabaseInfo;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.StmtExecutor;
+
+import com.google.common.base.Strings;
+import org.apache.commons.lang3.StringUtils;
+
+/**
+ * drop database command
+ */
+public class DropDatabaseCommand extends Command implements ForwardWithSync {
+ private final DropDatabaseInfo dropDatabaseInfo;
+
+ public DropDatabaseCommand(DropDatabaseInfo dropDatabaseInfo) {
+ super(PlanType.DROP_DATABASE_COMMAND);
+ this.dropDatabaseInfo = dropDatabaseInfo;
+ }
+
+ private void analyze(ConnectContext ctx) throws UserException {
+ String databaseName = dropDatabaseInfo.getDatabaseName();
+ String catalogName = dropDatabaseInfo.getCatalogName();
+ if (Strings.isNullOrEmpty(databaseName)) {
+ ErrorReport.reportAnalysisException(ErrorCode.ERR_WRONG_DB_NAME, databaseName);
+ }
+
+ InternalDatabaseUtil.checkDatabase(databaseName, ctx);
+
+ DatabaseIf db = Env.getCurrentInternalCatalog().getDbNullable(databaseName);
+ if (db != null && db instanceof MysqlCompatibleDatabase) {
+ ErrorReport.reportAnalysisException(ErrorCode.ERR_DBACCESS_DENIED_ERROR,
+ ctx.getQualifiedUser(), databaseName);
+ }
+
+ String effectiveCatalog = StringUtils.isEmpty(catalogName)
+ ? InternalCatalog.INTERNAL_CATALOG_NAME : catalogName;
Review Comment:
if catalogName is empty, we should use currentCatalog?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/DropDatabaseInfo.java:
##########
@@ -0,0 +1,70 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands.info;
+
+import org.apache.doris.analysis.DbName;
+import org.apache.doris.analysis.DropDbStmt;
+import org.apache.doris.common.AnalysisException;
+
+import java.util.List;
+
+/**
+ * drop database info
+ */
+public class DropDatabaseInfo {
+ private final boolean ifExists;
+ private final String catalogName;
+ private final String databaseName;
+ private final boolean force;
+
+ /**
+ * Constructor for DropDatabaseInfo.
+ */
+ public DropDatabaseInfo(boolean ifExists, List<String> databaseNameParts, boolean force) {
+ this.ifExists = ifExists;
+ if (databaseNameParts.size() > 1) {
+ this.catalogName = databaseNameParts.get(databaseNameParts.size() - 2);
+ this.databaseName = databaseNameParts.get(databaseNameParts.size() - 1);
+ } else {
Review Comment:
should only allow databaseNameParts == 2 || databaseNameParts == 1
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DropDatabaseCommand.java:
##########
@@ -0,0 +1,95 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands;
+
+import org.apache.doris.analysis.StmtType;
+import org.apache.doris.catalog.DatabaseIf;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.catalog.MysqlCompatibleDatabase;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.common.UserException;
+import org.apache.doris.common.util.InternalDatabaseUtil;
+import org.apache.doris.datasource.InternalCatalog;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.commands.info.DropDatabaseInfo;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.StmtExecutor;
+
+import com.google.common.base.Strings;
+import org.apache.commons.lang3.StringUtils;
+
+/**
+ * drop database command
+ */
+public class DropDatabaseCommand extends Command implements ForwardWithSync {
+ private final DropDatabaseInfo dropDatabaseInfo;
+
+ public DropDatabaseCommand(DropDatabaseInfo dropDatabaseInfo) {
+ super(PlanType.DROP_DATABASE_COMMAND);
+ this.dropDatabaseInfo = dropDatabaseInfo;
+ }
+
+ private void analyze(ConnectContext ctx) throws UserException {
+ String databaseName = dropDatabaseInfo.getDatabaseName();
+ String catalogName = dropDatabaseInfo.getCatalogName();
+ if (Strings.isNullOrEmpty(databaseName)) {
+ ErrorReport.reportAnalysisException(ErrorCode.ERR_WRONG_DB_NAME, databaseName);
+ }
+
+ InternalDatabaseUtil.checkDatabase(databaseName, ctx);
+
+ DatabaseIf db = Env.getCurrentInternalCatalog().getDbNullable(databaseName);
+ if (db != null && db instanceof MysqlCompatibleDatabase) {
+ ErrorReport.reportAnalysisException(ErrorCode.ERR_DBACCESS_DENIED_ERROR,
+ ctx.getQualifiedUser(), databaseName);
+ }
+
+ String effectiveCatalog = StringUtils.isEmpty(catalogName)
+ ? InternalCatalog.INTERNAL_CATALOG_NAME : catalogName;
+
+ if (!Env.getCurrentEnv().getAccessManager()
+ .checkDbPriv(ctx, effectiveCatalog, databaseName, PrivPredicate.DROP)) {
+ ErrorReport.reportAnalysisException(ErrorCode.ERR_DBACCESS_DENIED_ERROR,
+ ctx.getQualifiedUser(), databaseName);
+ }
+ }
+
+ @Override
+ public void run(ConnectContext ctx, StmtExecutor executor) throws Exception {
+ try {
+ analyze(ctx);
+ Env.getCurrentEnv().dropDb(dropDatabaseInfo.toDropDbStmt());
+ } catch (UserException e) {
+ throw new AnalysisException(e.getMessage(), e);
+ }
Review Comment:
why do this try catch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2576803710
<details>
<summary>ClickBench: <b>Total hot run time: 31.67 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3e82e48f49dbdf0830831d25ecce274403389ae8, data reload: false
query1 0.03 0.05 0.03
query2 0.07 0.04 0.03
query3 0.23 0.07 0.07
query4 1.61 0.11 0.10
query5 0.40 0.43 0.41
query6 1.18 0.65 0.65
query7 0.03 0.02 0.01
query8 0.04 0.03 0.03
query9 0.59 0.49 0.51
query10 0.56 0.56 0.55
query11 0.14 0.10 0.11
query12 0.13 0.11 0.11
query13 0.60 0.60 0.59
query14 2.80 2.75 2.83
query15 0.89 0.83 0.83
query16 0.39 0.38 0.38
query17 1.00 1.05 0.96
query18 0.25 0.21 0.21
query19 2.00 1.90 2.04
query20 0.01 0.01 0.01
query21 15.35 0.89 0.57
query22 0.75 0.93 0.57
query23 15.27 1.46 0.54
query24 2.69 1.44 1.51
query25 0.16 0.11 0.09
query26 0.33 0.15 0.13
query27 0.05 0.06 0.05
query28 13.69 1.52 1.04
query29 12.58 3.86 3.23
query30 0.25 0.09 0.06
query31 2.84 0.62 0.37
query32 3.23 0.56 0.46
query33 3.03 3.06 3.22
query34 16.76 5.14 4.58
query35 4.56 4.59 4.45
query36 0.66 0.48 0.48
query37 0.10 0.06 0.06
query38 0.04 0.04 0.04
query39 0.04 0.03 0.02
query40 0.16 0.14 0.14
query41 0.09 0.03 0.03
query42 0.04 0.03 0.02
query43 0.04 0.03 0.04
Total cold run time: 105.66 s
Total hot run time: 31.67 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #42935:
URL: https://github.com/apache/doris/pull/42935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "felixwluo (via GitHub)" <gi...@apache.org>.
felixwluo commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2586486455
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2453821228
<details>
<summary>TPC-H: <b>Total hot run time: 41592 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2888fb83af49d68fc16a4459ca65bd5a0a4f8dec, data reload: false
------ Round 1 ----------------------------------
q1 17636 7568 7417 7417
q2 2049 157 185 157
q3 10631 1143 1186 1143
q4 10297 810 799 799
q5 7774 3120 3037 3037
q6 243 146 150 146
q7 1037 606 605 605
q8 9372 1973 2020 1973
q9 6710 6426 6436 6426
q10 7084 2440 2436 2436
q11 470 263 262 262
q12 443 221 216 216
q13 17790 3000 3001 3000
q14 239 210 212 210
q15 570 529 513 513
q16 667 592 598 592
q17 978 586 512 512
q18 7381 6816 6738 6738
q19 1342 1044 972 972
q20 472 181 174 174
q21 4129 3338 3243 3243
q22 1140 1021 1028 1021
Total cold run time: 108454 ms
Total hot run time: 41592 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7340 7382 7309 7309
q2 327 223 227 223
q3 2914 2781 2801 2781
q4 1980 1732 1793 1732
q5 5496 5485 5529 5485
q6 218 140 139 139
q7 2173 1761 1714 1714
q8 3266 3460 3453 3453
q9 8579 8575 8609 8575
q10 3538 3480 3483 3480
q11 601 495 499 495
q12 791 604 579 579
q13 9560 3007 3032 3007
q14 312 280 257 257
q15 560 519 515 515
q16 682 640 633 633
q17 1879 1593 1571 1571
q18 7962 7459 7414 7414
q19 1667 1632 1518 1518
q20 2052 1829 1838 1829
q21 5490 5160 5296 5160
q22 1145 1009 998 998
Total cold run time: 68532 ms
Total hot run time: 58867 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2453891238
@felixwluo please update all old void dropDb(DropDbStmt stmt) method to call the new dropDb function you added to prevent duplicate code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "felixwluo (via GitHub)" <gi...@apache.org>.
felixwluo commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2448855406
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2579082138
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2574749676
<details>
<summary>TPC-DS: <b>Total hot run time: 196573 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a97f35931c6d7ac22dea10d932abbb1e52fb78da, data reload: false
query1 1293 960 910 910
query2 6293 2266 2350 2266
query3 11006 4804 4648 4648
query4 33168 23752 23400 23400
query5 3949 600 441 441
query6 267 188 178 178
query7 3990 486 292 292
query8 286 233 237 233
query9 9743 2792 2761 2761
query10 435 307 254 254
query11 17911 15378 15251 15251
query12 159 110 103 103
query13 1573 551 415 415
query14 10531 6967 7905 6967
query15 249 203 207 203
query16 8494 600 454 454
query17 1631 780 585 585
query18 2143 423 331 331
query19 218 204 182 182
query20 125 125 116 116
query21 259 117 106 106
query22 4661 4463 4534 4463
query23 34627 33921 33833 33833
query24 6491 2321 2333 2321
query25 492 466 411 411
query26 757 271 158 158
query27 2148 500 340 340
query28 5309 2535 2520 2520
query29 639 555 424 424
query30 216 187 146 146
query31 1022 936 850 850
query32 83 59 53 53
query33 483 352 295 295
query34 765 866 520 520
query35 807 815 764 764
query36 1039 1046 985 985
query37 121 110 104 104
query38 4203 4295 4124 4124
query39 1536 1466 1472 1466
query40 204 114 97 97
query41 43 41 46 41
query42 118 108 105 105
query43 526 521 507 507
query44 1374 839 837 837
query45 180 182 175 175
query46 887 1061 659 659
query47 1999 1987 1987 1987
query48 392 435 321 321
query49 724 475 418 418
query50 661 656 384 384
query51 7194 7018 7128 7018
query52 103 101 92 92
query53 225 258 188 188
query54 472 502 404 404
query55 84 79 83 79
query56 259 274 234 234
query57 1261 1262 1172 1172
query58 245 232 247 232
query59 3291 3306 3056 3056
query60 300 265 248 248
query61 108 107 106 106
query62 867 830 765 765
query63 232 184 185 184
query64 3286 1026 651 651
query65 3367 3253 3241 3241
query66 839 416 313 313
query67 16290 15948 15589 15589
query68 8072 697 516 516
query69 489 291 260 260
query70 1229 1133 1143 1133
query71 428 287 252 252
query72 6287 3907 3834 3834
query73 664 743 364 364
query74 10147 9153 8893 8893
query75 3925 3120 2664 2664
query76 3668 1172 771 771
query77 770 368 263 263
query78 10357 10043 9392 9392
query79 3512 813 588 588
query80 588 504 412 412
query81 488 266 226 226
query82 653 150 126 126
query83 160 163 140 140
query84 247 93 68 68
query85 790 353 355 353
query86 401 306 302 302
query87 4436 4564 4371 4371
query88 4611 2206 2202 2202
query89 420 330 302 302
query90 1800 182 185 182
query91 125 130 103 103
query92 66 52 49 49
query93 2105 852 527 527
query94 639 390 291 291
query95 334 263 250 250
query96 488 606 290 290
query97 2853 2926 2841 2841
query98 215 201 198 198
query99 1750 1568 1434 1434
Total cold run time: 297370 ms
Total hot run time: 196573 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](nereids) support drop database in nereids [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42935:
URL: https://github.com/apache/doris/pull/42935#issuecomment-2586586507
<details>
<summary>TPC-DS: <b>Total hot run time: 188537 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2e70d26dd5139ff9f156e837d8b9eb58fc576850, data reload: false
query1 965 373 370 370
query2 6526 2387 2363 2363
query3 6707 215 215 215
query4 33882 23497 23097 23097
query5 4392 628 463 463
query6 302 191 198 191
query7 4636 492 317 317
query8 301 247 236 236
query9 9673 2676 2667 2667
query10 466 323 254 254
query11 17788 15262 15174 15174
query12 150 107 102 102
query13 1643 514 389 389
query14 9238 7582 7619 7582
query15 250 206 196 196
query16 8755 599 427 427
query17 1644 754 577 577
query18 2126 432 289 289
query19 217 176 146 146
query20 114 115 109 109
query21 209 124 104 104
query22 4271 4212 4055 4055
query23 33603 32985 33176 32985
query24 6364 2204 2300 2204
query25 507 447 381 381
query26 1180 272 165 165
query27 2001 457 334 334
query28 5217 2426 2400 2400
query29 725 534 415 415
query30 233 191 152 152
query31 937 928 795 795
query32 89 61 71 61
query33 516 353 344 344
query34 761 834 513 513
query35 785 801 721 721
query36 1031 1029 948 948
query37 132 103 77 77
query38 4195 4007 3919 3919
query39 1474 1413 1400 1400
query40 203 118 105 105
query41 52 52 49 49
query42 127 111 103 103
query43 506 521 501 501
query44 1267 805 801 801
query45 178 171 180 171
query46 845 1047 638 638
query47 1768 1796 1764 1764
query48 368 386 319 319
query49 783 507 408 408
query50 613 650 386 386
query51 6912 6831 6717 6717
query52 106 109 90 90
query53 229 245 184 184
query54 493 500 415 415
query55 83 81 78 78
query56 260 260 257 257
query57 1159 1144 1078 1078
query58 252 234 246 234
query59 2976 3000 2995 2995
query60 274 272 249 249
query61 120 114 116 114
query62 863 750 693 693
query63 228 198 190 190
query64 4181 1002 654 654
query65 3253 3175 3139 3139
query66 1075 415 319 319
query67 15920 15675 15366 15366
query68 8034 775 517 517
query69 486 355 263 263
query70 1187 1107 1081 1081
query71 448 302 261 261
query72 6138 3880 3849 3849
query73 653 740 360 360
query74 10245 9171 8740 8740
query75 3782 3158 2668 2668
query76 3647 1168 754 754
query77 775 387 292 292
query78 9950 9861 9435 9435
query79 3807 785 597 597
query80 673 594 443 443
query81 497 285 238 238
query82 627 150 122 122
query83 171 176 151 151
query84 245 101 86 86
query85 780 376 309 309
query86 394 326 298 298
query87 4247 4408 4459 4408
query88 4936 2161 2143 2143
query89 413 334 297 297
query90 1762 203 198 198
query91 133 137 109 109
query92 69 62 54 54
query93 2044 883 528 528
query94 656 408 294 294
query95 340 268 267 267
query96 492 617 275 275
query97 2869 2925 2764 2764
query98 226 204 203 203
query99 1438 1501 1379 1379
Total cold run time: 291263 ms
Total hot run time: 188537 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org