[GitHub] [incubator-iceberg] rdblue commented on pull request #939: Support UpdateEvent for Update Operations

[GitBox <gi...@apache.org>]

rdblue commented on pull request #939:
URL: https://github.com/apache/incubator-iceberg/pull/939#issuecomment-623557860


   Overall, I think this is ready. I'd prefer to use `current` instead of `refresh` in the `updateEvent` methods, though. I'd probably wait to merge until then.
   
   It would also be good to follow up with events in snapshot manager: rollback, fast-forward, and set current snapshot.
   
   Last, I think that this is going to send events each time an individual operation is committed in a transaction. That's okay for now, but we may want to go back through and suppress events during a transaction and then send them all at once when the transaction succeeds. That will handle retries better.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org