You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/21 10:32:37 UTC

[GitHub] [pulsar] eolivelli opened a new pull request #10303: Transaction: remove duplicate debug log

eolivelli opened a new pull request #10303:
URL: https://github.com/apache/pulsar/pull/10303


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] eolivelli commented on a change in pull request #10303: Transaction: remove duplicate debug log

Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #10303:
URL: https://github.com/apache/pulsar/pull/10303#discussion_r617416438



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TransactionBufferHandlerImpl.java
##########
@@ -149,7 +149,6 @@ public void handleEndTxnOnTopicResponse(long requestId, CommandEndTxnOnPartition
             if (log.isDebugEnabled()) {
                 log.debug("[{}] Got end txn on topic response for for request {}", op.topic, response.getRequestId());
             }
-            log.info("[{}] Got end txn on topic response for for request {}", op.topic, response.getRequestId());

Review comment:
       this line is printed at debug level two lines above, probably is is a left over during development.
   
   actually this line fills of spam broker logs during load testing




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] merlimat merged pull request #10303: Transaction: remove duplicate debug log

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10303:
URL: https://github.com/apache/pulsar/pull/10303


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] aahmed-se commented on pull request #10303: Transaction: remove duplicate debug log

Posted by GitBox <gi...@apache.org>.
aahmed-se commented on pull request #10303:
URL: https://github.com/apache/pulsar/pull/10303#issuecomment-824275464


   Please update the description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org