[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29035: [SPARK-32220][SQL]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #29035:
URL: https://github.com/apache/spark/pull/29035#discussion_r452587223



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/EliminateResolvedHint.scala
##########
@@ -43,6 +43,22 @@ object EliminateResolvedHint extends Rule[LogicalPlan] {
       case h: ResolvedHint =>
         hintErrorHandler.joinNotFoundForJoinHint(h.hints)
         h.child
+      case join: Join if join.condition.isDefined =>
+        join.copy(
+          hint = join.hint.copy(
+            leftHint = removeCartesianProductJoinHint(join.hint.leftHint),
+            rightHint = removeCartesianProductJoinHint(join.hint.rightHint)))
+    }
+  }
+
+  def removeCartesianProductJoinHint(hint: Option[HintInfo]): Option[HintInfo] = {

Review comment:
       @maropu See latest change, it's ok to do like this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org