Re: [PR] fix: Fail fast on async query websocket misconfiguration [superset]

["bito-code-review[bot] (via GitHub)" <gi...@apache.org>]

bito-code-review[bot] commented on PR #37809:
URL: https://github.com/apache/superset/pull/37809#issuecomment-4702710420

   <!-- Bito Reply -->
   The suggestion is appropriate and improves the test's robustness. Asserting the exception message ensures that the test specifically validates the configuration error path, preventing future regressions where the exception might be raised for a different reason while still matching the same exception type.
   
   **tests/unit_tests/async_events/async_query_manager_tests.py**
   ```
   with raises(AsyncQueryTokenException) as excinfo:
           manager.init_app(app)
       assert "GLOBAL_ASYNC_QUERIES_REGISTER_REQUEST_HANDLERS" in str(excinfo.value)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org