You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/07/27 11:14:50 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #3630: HDDS-7055. NPE in ec.reconstruction.TokenHelper
adoroszlai opened a new pull request, #3630:
URL: https://github.com/apache/ozone/pull/3630
## What changes were proposed in this pull request?
Fix the exception:
```
ERROR org.apache.hadoop.ozone.HddsDatanodeService: Exception in HddsDatanodeService.
java.lang.NullPointerException
at org.apache.hadoop.ozone.container.ec.reconstruction.TokenHelper.<init>(TokenHelper.java:68)
at org.apache.hadoop.ozone.container.ec.reconstruction.ECReconstructionCoordinator.<init>(ECReconstructionCoordinator.java:119)
at org.apache.hadoop.ozone.container.common.statemachine.DatanodeStateMachine.<init>(DatanodeStateMachine.java:185)
at org.apache.hadoop.ozone.HddsDatanodeService.start(HddsDatanodeService.java:279)
```
triggered by such config:
```xml
<property>
<name>hdds.block.token.enabled</name>
<value>true</value>
</property>
<property>
<name>hdds.container.token.enabled</name>
<value>true</value>
</property>
<property>
<name>ozone.security.enabled</name>
<value>false</value>
</property>
```
`TokenHelper` still allows this config (as required for `TestContainerCommandsEC` integration test), but checks if certificate client is present or not.
https://issues.apache.org/jira/browse/HDDS-7055
## How was this patch tested?
Updated `TestHddsDatanodeService` with configuration as above to verify `HddsDatanodeService` can be started successfully.
`TestContainerCommandsEC` covers functionality of `TokenHelper` with tokens enabled.
https://github.com/adoroszlai/hadoop-ozone/actions/runs/2745224823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl merged pull request #3630: HDDS-7055. NPE in ec.reconstruction.TokenHelper
Posted by GitBox <gi...@apache.org>.
smengcl merged PR #3630:
URL: https://github.com/apache/ozone/pull/3630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3630: HDDS-7055. NPE in ec.reconstruction.TokenHelper
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3630:
URL: https://github.com/apache/ozone/pull/3630#issuecomment-1197133068
Thanks all for the review. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on a diff in pull request #3630: HDDS-7055. NPE in ec.reconstruction.TokenHelper
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on code in PR #3630:
URL: https://github.com/apache/ozone/pull/3630#discussion_r931177404
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/TestHddsDatanodeService.java:
##########
@@ -50,6 +54,9 @@ public void setUp() {
conf.set(HddsConfigKeys.OZONE_METADATA_DIRS, testDir.getPath());
conf.setClass(OzoneConfigKeys.HDDS_DATANODE_PLUGINS_KEY, MockService.class,
ServicePlugin.class);
+ conf.setBoolean(OZONE_SECURITY_ENABLED_KEY, false);
Review Comment:
It's ok to set here again for better understanding the situation. Can you add a comment, why we set them this way?
Just include JIRA ID also. Thanks.
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/TestHddsDatanodeService.java:
##########
@@ -50,6 +54,9 @@ public void setUp() {
conf.set(HddsConfigKeys.OZONE_METADATA_DIRS, testDir.getPath());
conf.setClass(OzoneConfigKeys.HDDS_DATANODE_PLUGINS_KEY, MockService.class,
ServicePlugin.class);
+ conf.setBoolean(OZONE_SECURITY_ENABLED_KEY, false);
Review Comment:
by default security is false right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org