You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/01/22 04:13:46 UTC
[kudu-CR] Support move constructor and assignment operator in scoped_refptr
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/1870
to review the following change.
Change subject: Support move constructor and assignment operator in scoped_refptr
......................................................................
Support move constructor and assignment operator in scoped_refptr
This is a port over of 4c3de21a3dcdd9e27a770572350eeaa98cdb9e87 from
the chromium-base repository.
The port isn't 100% -- on their side they added a .Pass() to scoped_refptr.
However, I think in our case we should just use std::move() for this use case.
Change-Id: I339c9f6c3bfc0fcacd44aa53bdd75d723b9aab47
---
M src/kudu/gutil/ref_counted.h
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/1870/1
--
To view, visit http://gerrit.cloudera.org:8080/1870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I339c9f6c3bfc0fcacd44aa53bdd75d723b9aab47
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>