You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/10/30 05:45:01 UTC

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build

gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build
URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r340438433
 
 

 ##########
 File path: be/src/olap/key_coder.h
 ##########
 @@ -41,14 +42,20 @@ class KeyCoder {
     template<typename TraitsType>
     KeyCoder(TraitsType traits);
 
+    void full_encode_ascending(const void* value, std::string* buf) const {
 
 Review comment:
   OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org