You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/16 23:15:21 UTC

[GitHub] [spark] dongjoon-hyun commented on pull request #31571: [SPARK-34445][SQL][DOCS] Make `spark.sql.legacy.replaceDatabricksSparkAvro.enabled` as non-internal

dongjoon-hyun commented on pull request #31571:
URL: https://github.com/apache/spark/pull/31571#issuecomment-780179070


   No, I don't. `Removing a config w/o deprecation` sounds wrong.
   > Do you consider a situation when you can just remove this config w/o deprecation only because it is marked as .internal()?
   
   No. I disagree with the expression, `de facto`. The documentation change is far much easier than removing `non-internal` config.
   > it is external de facto. 
   
   Like https://github.com/databricks/spark-avro says, only `Databricks customer` can use this library directly . All other distributions, especially 3.2.0+ versions, I don't think this PR makes sense.
   > Databricks customers can also use this library directly on the Databricks Unified Analytics Platform without any additional dependency configurations.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org